From owner-cvs-src@FreeBSD.ORG Sun Dec 12 20:41:13 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 283D616A4CE; Sun, 12 Dec 2004 20:41:13 +0000 (GMT) Received: from electra.cse.Buffalo.EDU (electra.cse.Buffalo.EDU [128.205.32.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id B9B3043D2D; Sun, 12 Dec 2004 20:41:12 +0000 (GMT) (envelope-from kensmith@cse.Buffalo.EDU) Received: from electra.cse.Buffalo.EDU (kensmith@localhost [127.0.0.1]) iBCKfCIo005825; Sun, 12 Dec 2004 15:41:12 -0500 (EST) Received: (from kensmith@localhost) by electra.cse.Buffalo.EDU (8.12.10/8.12.9/Submit) id iBCKfC7i005824; Sun, 12 Dec 2004 15:41:12 -0500 (EST) Date: Sun, 12 Dec 2004 15:41:11 -0500 From: Ken Smith To: Brooks Davis Message-ID: <20041212204111.GB5503@electra.cse.Buffalo.EDU> References: <200412122012.iBCKCou6068020@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200412122012.iBCKCou6068020@repoman.freebsd.org> User-Agent: Mutt/1.4.1i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sbin/ifconfig ifconfig.c src/sys/net if.c if.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Dec 2004 20:41:13 -0000 On Sun, Dec 12, 2004 at 08:12:50PM +0000, Brooks Davis wrote: > brooks 2004-12-12 20:12:50 UTC > > FreeBSD src repository > > Modified files: (Branch: RELENG_4) > sbin/ifconfig ifconfig.c > sys/net if.c if.h > Log: > MFC the addition of ifi_datalen to struct if_data and ifconfig support > for it. The change to struct if_data differs slightly from the one in > 5.3 in that a pad is added after ifi_xmitquota rather then adding > ifi_link_state before ifi_recvquota. This is necessicary to maintain > the 4.x ABI. > > Revision Changes Path > 1.51.2.23 +4 -1 src/sbin/ifconfig/ifconfig.c > 1.85.2.28 +2 -0 src/sys/net/if.c > 1.58.2.12 +2 -0 src/sys/net/if.h In if.h you are adding new fields that didn't exist before: #ifndef _NET_IF_H_ @@ -97,6 +97,8 @@ struct if_data { u_char ifi_hdrlen; /* media header length */ u_char ifi_recvquota; /* polling quota for receive intrs */ u_char ifi_xmitquota; /* polling quota for xmit intrs */ + u_char ifi_do_no_use; /* pad for ifi_datalen's position */ + u_char ifi_datalen; /* length of this data struct */ u_long ifi_mtu; /* maximum transmission unit */ u_long ifi_metric; /* routing metric (external only) */ u_long ifi_baudrate; /* linespeed */ So any already compiled executables that use the if_data structure would be looking for ifi_mtu/ifi_metric/ifi_baudrate in the wrong place after this change. Are you absolutely sure this is not breaking ABI? Thanks. -- Ken Smith - From there to here, from here to | kensmith@cse.buffalo.edu there, funny things are everywhere. | - Theodore Geisel |