From owner-svn-src-user@FreeBSD.ORG Thu Sep 29 08:48:36 2011 Return-Path: Delivered-To: svn-src-user@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E2CEB106564A; Thu, 29 Sep 2011 08:48:36 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-fx0-f54.google.com (mail-fx0-f54.google.com [209.85.161.54]) by mx1.freebsd.org (Postfix) with ESMTP id 2662E8FC0A; Thu, 29 Sep 2011 08:48:35 +0000 (UTC) Received: by fxg9 with SMTP id 9so2073287fxg.13 for ; Thu, 29 Sep 2011 01:48:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:x-enigmail-version:content-type :content-transfer-encoding; bh=n5a2iXcRw55H4XXrZlo/5iu/54SOr7iarrTLkcjC2fM=; b=mvryP/sG10aMq9MSo0PZyfllIyzK14CCWh9UtEM64Zarjq6xt0PpX7s3adljJCSe/Y B8E3PQ4eyKhJA8YysbUd+qCsXLxlArG/ZDmmACx39I+Qea9g6xlo/aEWqBZJYSH1wGj3 hmzYVrNeUeTL4WQOZQlhaKEGHmRL6O/FdjKys= Received: by 10.223.37.91 with SMTP id w27mr2946650fad.111.1317286115077; Thu, 29 Sep 2011 01:48:35 -0700 (PDT) Received: from mavbook2.mavhome.dp.ua (pc.mavhome.dp.ua. [212.86.226.226]) by mx.google.com with ESMTPS id x22sm1310723faa.5.2011.09.29.01.48.33 (version=SSLv3 cipher=OTHER); Thu, 29 Sep 2011 01:48:34 -0700 (PDT) Sender: Alexander Motin Message-ID: <4E8430D9.3060602@FreeBSD.org> Date: Thu, 29 Sep 2011 11:48:25 +0300 From: Alexander Motin User-Agent: Thunderbird 2.0.0.23 (X11/20091212) MIME-Version: 1.0 To: Adrian Chadd References: <201109290310.p8T3AgZO001901@svn.freebsd.org> <4E84222F.7050101@FreeBSD.org> In-Reply-To: X-Enigmail-Version: 0.96.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: src-committers@freebsd.org, svn-src-user@freebsd.org Subject: Re: svn commit: r225860 - user/adrian/if_ath_tx/sys/mips/mips X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the experimental " user" src tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Sep 2011 08:48:37 -0000 Adrian Chadd wrote: > .. yes, spinlock_enter() / spinlock_exit() in mips does save/restore > the interrupt context. > So if they were disabled, they should continue being disabled. Ah, sorry, probably I've mixed it with something else. But still I see no reason to cover all the critical section with the disabled interrupts. It will just increase race window before the wait instruction and increase problem hit probability. -- Alexander Motin