From owner-cvs-all Fri Dec 20 12:59:23 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CCB3C37B406; Fri, 20 Dec 2002 12:59:22 -0800 (PST) Received: from apollo.backplane.com (apollo.backplane.com [216.240.41.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id 794BD43EE6; Fri, 20 Dec 2002 12:59:22 -0800 (PST) (envelope-from dillon@apollo.backplane.com) Received: from apollo.backplane.com (localhost [127.0.0.1]) by apollo.backplane.com (8.12.5/8.12.5) with ESMTP id gBKKxKOM083599; Fri, 20 Dec 2002 12:59:21 -0800 (PST) (envelope-from dillon@apollo.backplane.com) Received: (from dillon@localhost) by apollo.backplane.com (8.12.5/8.12.5/Submit) id gBKKxK0l083598; Fri, 20 Dec 2002 12:59:20 -0800 (PST) (envelope-from dillon) Date: Fri, 20 Dec 2002 12:59:20 -0800 (PST) From: Matthew Dillon Message-Id: <200212202059.gBKKxK0l083598@apollo.backplane.com> To: Scott Long Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/dev/usb ohci.c References: <200212201847.gBKIldGZ071133@repoman.freebsd.org> <3E03820D.4070004@btc.adaptec.com> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG :Matt, : :While the effort that you put into this problem is without doubt :appreciated, I wonder why you chose this approach rather that converting :the driver to use busdma? NetBSD and OpenBSD use busdma, although of :course their implementation differs from ours. The FreeBSD code is :already ugly enough since alpha is special cased and I doubt that ia64 :or sparc64 could possibly work. And as you point out, your hack still :isn't totally correct. : :Scott I'm just fixing bugs at the moment. I don't really have time to rewrite the code, at least not now (I'm the VM guy, not the device driver guy, remember?). I think it's preferable to fix the bugs verses doing nothing at all. -Matt Matthew Dillon To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message