From owner-svn-src-all@freebsd.org Tue May 17 00:20:39 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9CAF8B3D6C6; Tue, 17 May 2016 00:20:39 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-qg0-x22a.google.com (mail-qg0-x22a.google.com [IPv6:2607:f8b0:400d:c04::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4F62A10F1; Tue, 17 May 2016 00:20:39 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-qg0-x22a.google.com with SMTP id f74so257498qge.2; Mon, 16 May 2016 17:20:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=Wu55Jb0SH8TNgaeGWq5DJOrqfV/bJhA3CJDycdOVqqY=; b=KyAfZ46LYuPNnsNHU7rIw58+GqKwcp+Jyxg/enWCk2NkUpvoG2Gv5U/ueZaB5gDJZf uh5eFM5af8uW6EkP84EN7zTneBaQRVgg3ebPEHRvNaVjSVMKuc3klO+XMskMk5av0NLJ Ux6iPNVp1zFzSyjGkAv96CXvlOLI7RLlgd0oyIG5qyfkgEqmo/lSF5wmdV5A5Ig8Xb+J unnt94XKq/Bw7dg13CvItJ6xC+VnKoEH+d9Ys1hGCbwLTwx1HS0dL1qJXJZk/V+1z5XG qDwkqgvni4LiyYaElQt0a8Uuiazv5PPkiFglEtOgrT6uBhK9q8nXnIazdjuPlsAcWnr4 JGbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=Wu55Jb0SH8TNgaeGWq5DJOrqfV/bJhA3CJDycdOVqqY=; b=d/bdYBpC4xJjjCoFUUlVjl8poE8d17LGwD40/hVgm3648NUekUTmu+2rN85JIuV3gE z0R3x1WX5h+bdlJ7b9j3Vz59vAWqQe1/lR/oqZ9vx+ZQ3nWYs4qUYMq3Pe66/g9xm45d yrWADyGZvISufp8QljvUhYKS7if3xI1nNmqVCangCgfgJNI+2jHVrIJTgd9DSSzUwOnA 1H7YN/Pjnn1vu+Csp6ZLdetOQ54YWFg1OmRHgZOUI9RJIC9cd5us6dWsWn95OHGaI1rT 8d3ZpaQ4GYp+77S9yYHDU9yR91yGC+vnaj55iUMSFPFSaSXUAZZ5FayJjarhFr7DeJaj LqHw== X-Gm-Message-State: AOPr4FVxHkt288s164FxPDH7q9FdSkyYLql9Taczu7BWY3uY84PD050DCWnA02zPlhP92/kpUlgnyyRz/XKvhw== MIME-Version: 1.0 X-Received: by 10.141.44.135 with SMTP id v129mr34035174qhe.46.1463444438430; Mon, 16 May 2016 17:20:38 -0700 (PDT) Received: by 10.55.170.201 with HTTP; Mon, 16 May 2016 17:20:38 -0700 (PDT) In-Reply-To: <201605170008.u4H08hEB098976@repo.freebsd.org> References: <201605170008.u4H08hEB098976@repo.freebsd.org> Date: Mon, 16 May 2016 17:20:38 -0700 Message-ID: Subject: Re: svn commit: r299995 - head/usr.bin/kdump From: Ngie Cooper To: "Simon J. Gerraty" Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 May 2016 00:20:39 -0000 On Mon, May 16, 2016 at 5:08 PM, Simon J. Gerraty wrote: > Author: sjg > Date: Tue May 17 00:08:43 2016 > New Revision: 299995 > URL: https://svnweb.freebsd.org/changeset/base/299995 > > Log: > Allow -f - to read from stdin. > > Modified: > head/usr.bin/kdump/kdump.c > > Modified: head/usr.bin/kdump/kdump.c > ============================================================================== > --- head/usr.bin/kdump/kdump.c Tue May 17 00:00:01 2016 (r299994) > +++ head/usr.bin/kdump/kdump.c Tue May 17 00:08:43 2016 (r299995) > @@ -298,8 +298,9 @@ main(int argc, char *argv[]) > m = malloc(size = 1025); > if (m == NULL) > errx(1, "%s", strerror(ENOMEM)); > - if (!freopen(tracefile, "r", stdin)) > - err(1, "%s", tracefile); > + if (strcmp(tracefile, "-")) Please use `!= 0` for explicitness. Thanks, -Ngie