From owner-freebsd-bugs@FreeBSD.ORG  Thu May 30 07:54:36 2013
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@freebsd.org
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id 2C213F5C;
 Thu, 30 May 2013 07:54:36 +0000 (UTC)
 (envelope-from luigi@onelab2.iet.unipi.it)
Received: from onelab2.iet.unipi.it (onelab2.iet.unipi.it [131.114.59.238])
 by mx1.freebsd.org (Postfix) with ESMTP id E5532878;
 Thu, 30 May 2013 07:54:35 +0000 (UTC)
Received: by onelab2.iet.unipi.it (Postfix, from userid 275)
 id 26FFE7300B; Thu, 30 May 2013 09:57:15 +0200 (CEST)
Date: Thu, 30 May 2013 09:57:15 +0200
From: Luigi Rizzo <rizzo@iet.unipi.it>
To: freebsd-bugs@freebsd.org, freebsd-net@freebsd.org
Subject: Re: kern/179083: [netmap] [patch] Invalid index calucation in
 netmap macro expansion
Message-ID: <20130530075715.GA64174@onelab2.iet.unipi.it>
References: <201305300743.r4U7hlE3088879@freefall.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201305300743.r4U7hlE3088879@freefall.freebsd.org>
User-Agent: Mutt/1.5.20 (2009-06-14)
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 30 May 2013 07:54:36 -0000

On Thu, May 30, 2013 at 07:43:47AM +0000, linimon@freebsd.org wrote:
> Old Synopsis: Invalid index calucation in netmap macro expansion
> New Synopsis: [netmap] [patch] Invalid index calucation in netmap macro expansion
> 
> Responsible-Changed-From-To: freebsd-bugs->freebsd-net
> Responsible-Changed-By: linimon
> Responsible-Changed-When: Thu May 30 07:43:27 UTC 2013
> Responsible-Changed-Why: 
> Over to maintainer(s).

Thanks for the report.

The macro is correct as implemented.
The problem, in case, is in the description in netmap_user.h which
is confusing and should be improved as follows:

-*      char *buf = NETMAP_BUF(ring, index) returns a pointer to
-*              the i-th buffer
+*      char *buf = NETMAP_BUF(ring, x) returns a pointer to
+*              the buffer numbered 'x'

This will be committed soon, so please close the PR

cheers
luigi

> http://www.freebsd.org/cgi/query-pr.cgi?pr=179083
> _______________________________________________
> freebsd-net@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-net
> To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org"