From owner-cvs-all@FreeBSD.ORG  Wed Feb 28 06:08:47 2007
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id A2D5016E9CC;
	Wed, 28 Feb 2007 06:08:47 +0000 (UTC)
	(envelope-from phk@critter.freebsd.dk)
Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222])
	by mx1.freebsd.org (Postfix) with ESMTP id 4000B13C442;
	Wed, 28 Feb 2007 06:08:47 +0000 (UTC)
	(envelope-from phk@critter.freebsd.dk)
Received: from critter.freebsd.dk (critter.freebsd.dk [192.168.48.2])
	by phk.freebsd.dk (Postfix) with ESMTP id A54FF170DC;
	Wed, 28 Feb 2007 06:08:45 +0000 (UTC)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.13.8/8.13.8) with ESMTP id l1S68jSN042089;
	Wed, 28 Feb 2007 06:08:45 GMT (envelope-from phk@critter.freebsd.dk)
To: Warner Losh <imp@FreeBSD.org>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Tue, 27 Feb 2007 22:33:50 GMT."
	<200702272233.l1RMXocb004983@repoman.freebsd.org> 
Date: Wed, 28 Feb 2007 06:08:45 +0000
Message-ID: <42088.1172642925@critter.freebsd.dk>
Sender: phk@critter.freebsd.dk
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/dev/usb umass.c 
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 28 Feb 2007 06:08:47 -0000

In message <200702272233.l1RMXocb004983@repoman.freebsd.org>, Warner Losh write
s:

>  Some USB mass storage devices return the number of sectors in response
>  to a READ_CAPACITY request rather than the maximum sector (off by one
>  problem).  This causes a huge cascade of errors as the geom tasting
>  code tries to read the last sector (which isn't really there in the
>  face of this error).  automated tools that manipulate disk labels and
>  such also have issues.
>  
>  Create a new quirk READ_CAPACITY_OFFBY1 

A better idea would be to have scsi_da.c try to read the 
last sector and chop it if it fails.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.