From owner-freebsd-multimedia@FreeBSD.ORG Sat Dec 17 11:46:17 2005 Return-Path: X-Original-To: freebsd-multimedia@freebsd.org Delivered-To: freebsd-multimedia@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1876416A41F for ; Sat, 17 Dec 2005 11:46:17 +0000 (GMT) (envelope-from skywizard@MyBSD.org.my) Received: from tomoyo.MyBSD.org.my (tomoyo.mybsd.org.my [202.157.186.227]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2BB0743D53 for ; Sat, 17 Dec 2005 11:46:15 +0000 (GMT) (envelope-from skywizard@MyBSD.org.my) Received: from localhost (localhost [127.0.0.1]) by tomoyo.MyBSD.org.my (Postfix) with ESMTP id 664806CC36; Sat, 17 Dec 2005 19:51:23 +0800 (MYT) Received: from tomoyo.MyBSD.org.my ([127.0.0.1]) by localhost (TOMOYO.MYBSD.ORG.MY [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 73374-07; Sat, 17 Dec 2005 19:51:20 +0800 (MYT) Received: from misaki (unknown [219.95.202.232]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by tomoyo.MyBSD.org.my (Postfix) with ESMTP id A27BA6CC2C; Sat, 17 Dec 2005 19:51:19 +0800 (MYT) Date: Sat, 17 Dec 2005 19:46:04 +0800 From: Ariff Abdullah To: Kazuhito HONDA Message-Id: <20051217194604.7e6c08dd.skywizard@MyBSD.org.my> In-Reply-To: <20051217.033715.343188712.kazuhito@ph.noda.tus.ac.jp> References: <20051217.033715.343188712.kazuhito@ph.noda.tus.ac.jp> Organization: MyBSD X-Mailer: /usr/local/lib/ruby/1.8/net/smtp.rb Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Virus-Scanned: by Amavisd AntiVirus & AntiSpam Scanner running on FreeBSD mailserver at TOMOYO.MYBSD.ORG.MY Cc: freebsd-multimedia@freebsd.org Subject: Re: patch for 24-bit soft volume and uaudio's tiny fix X-BeenThere: freebsd-multimedia@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Multimedia discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Dec 2005 11:46:17 -0000 On Sat, 17 Dec 2005 03:37:15 +0900 (JST) Kazuhito HONDA wrote: > Hello, > > We have already had a soft volume, feeder_volume_s16(). > But it is of 16 bit. So 24-bit sound streams are > always downgraded to 16-bit before soft volume > even though a sound device has a 24-bit port. > Thus 24-bit soft volume is necessary. > > This mail has a patch for 24-bit soft volume. > I tried to use it with `SB Live! 24-bit external' > and it worked. > > And the patch includes a fix of tiny mistakes in uaudio.c, too. > uaudio.c: Obvious mistake that need to be fixed. feeder_volume.c: Ok, looks good. My concern is endianess issue, but this can be ignored for now. I need to examine it first. channel.c: Changes against feeder building process is a bit sensitive, some brute testing need to be done here. Thanks. -- Ariff Abdullah MyBSD http://www.MyBSD.org.my (IPv6/IPv4) http://staff.MyBSD.org.my (IPv6/IPv4) http://tomoyo.MyBSD.org.my (IPv6/IPv4)