From owner-freebsd-ports Fri Mar 2 10:41:19 2001 Delivered-To: freebsd-ports@freebsd.org Received: from gw.nectar.com (gw.nectar.com [208.42.49.153]) by hub.freebsd.org (Postfix) with ESMTP id 7635F37B71A for ; Fri, 2 Mar 2001 10:41:17 -0800 (PST) (envelope-from nectar@nectar.com) Received: from hamlet.nectar.com (hamlet.nectar.com [10.0.1.102]) by gw.nectar.com (Postfix) with ESMTP id 9882A18C97; Fri, 2 Mar 2001 12:41:16 -0600 (CST) Received: (from nectar@localhost) by hamlet.nectar.com (8.11.2/8.9.3) id f22IfGv63130; Fri, 2 Mar 2001 12:41:16 -0600 (CST) (envelope-from nectar@spawn.nectar.com) Date: Fri, 2 Mar 2001 12:41:16 -0600 From: "Jacques A. Vidrine" To: Garrett Rooney Cc: ports@FreeBSD.org Subject: Re: [patch] which package functionality for pkg_info Message-ID: <20010302124116.A63107@hamlet.nectar.com> References: <3A9E8D0C.A24FD064@FreeBSD.org> <20010301133020.A23453@electricjellyfish.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20010301133020.A23453@electricjellyfish.net>; from rooneg@electricjellyfish.net on Thu, Mar 01, 2001 at 01:30:20PM -0500 X-Url: http://www.nectar.com/ Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org On Thu, Mar 01, 2001 at 01:30:20PM -0500, Garrett Rooney wrote: > On Thu, Mar 01, 2001 at 07:55:24PM +0200, Maxim Sobolev wrote: > > Please also try to review usage of MAXPATHLEN vs. FILENAME_MAX, I supect that > > you should use one of these uniformely across the code. > > after looking at the rest of the code, i've changed everything to use > FILENAME_MAX. it's more consistent, and they're defined to be the same thing > anyway. Actually you want PATH_MAX. For our platform, FILENAME_MAX == PATH_MAX, but that is not the same everywhere. When you use `FILENAME_MAX', you are talking about the length of a single path component (e.g. "foo-1.2"). Use `PATH_MAX' when you mean a path name (e.g. "./foo-1.2" or "/var/db/pkg/foo-1.2"). Cheers, -- Jacques Vidrine / n@nectar.com / jvidrine@verio.net / nectar@FreeBSD.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message