From owner-freebsd-current@FreeBSD.ORG  Thu Jun  7 18:19:01 2007
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: current@freebsd.org
Delivered-To: freebsd-current@FreeBSD.ORG
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 5B54E16A400
	for <current@freebsd.org>; Thu,  7 Jun 2007 18:19:01 +0000 (UTC)
	(envelope-from julian@elischer.org)
Received: from outR.internet-mail-service.net (outR.internet-mail-service.net
	[216.240.47.241])
	by mx1.freebsd.org (Postfix) with ESMTP id 3678E13C45A
	for <current@freebsd.org>; Thu,  7 Jun 2007 18:19:01 +0000 (UTC)
	(envelope-from julian@elischer.org)
Received: from mx0.idiom.com (HELO idiom.com) (216.240.32.160)
	by out.internet-mail-service.net (qpsmtpd/0.32) with ESMTP;
	Thu, 07 Jun 2007 11:19:00 -0700
Received: from julian-mac.elischer.org (nat.ironport.com [63.251.108.100])
	by idiom.com (Postfix) with ESMTP id 9A602125A2A;
	Thu,  7 Jun 2007 11:19:00 -0700 (PDT)
Message-ID: <46684C1A.7050809@elischer.org>
Date: Thu, 07 Jun 2007 11:19:06 -0700
From: Julian Elischer <julian@elischer.org>
User-Agent: Thunderbird 2.0.0.0 (Macintosh/20070326)
MIME-Version: 1.0
To: Ian FREISLICH <ianf@clue.co.za>
References: <E1HwDoF-000BLX-SX@clue.co.za>
In-Reply-To: <E1HwDoF-000BLX-SX@clue.co.za>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: current@freebsd.org
Subject: Re: Panic in ipfw
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 07 Jun 2007 18:19:01 -0000

Ian FREISLICH wrote:
> Hi
> 
> I got this panic yesterday on a fairly busy firewall.  I have some
> private patches to ip_fw2.c and to the em driver (see the earlier
> "em0 hijacking traffic to port 623" thread).  I don't think this
> panic is a result of those changes.
> 
> It occurred round about the time an address was added to an interface.
> 
> I'll keep the crashdump around for a while in case anyone wants more data.
> 
> FreeBSD firewall2 7.0-CURRENT FreeBSD 7.0-CURRENT #4: Thu May 24 10:43:20 SAST 2007     ianf@firewall2:/usr/obj/usr/src/sys/FIREWALL  i386
>

There is no locking to say between the firewall and the interface addresses.
it probably followed a bad pointer when the addresses were changed..

your bug report should say

"ipfw doesn't take part in interface address locking,
leading to occasional crashes"


> 2929                                            INADDR_TO_IFP(src_ip, tif);
> (kgdb) l
> 2924
> 2925                            case O_IP_SRC_ME:
> 2926                                    if (is_ipv4) {
> 2927                                            struct ifnet *tif;
> 2928
> 2929                                            INADDR_TO_IFP(src_ip, tif);
> 2930                                            match = (tif != NULL);
> 2931                                    }
> 2932                                    break;
> 2933
> (kgdb) print src_ip
> $1 = {s_addr = 3268032198}
> (kgdb) print tif
> Variable "tif" is not available.
> (kgdb) print *tif
> Variable "tif" is not available.
> 
> 
> --
> Ian Freislich
> 
> _______________________________________________
> freebsd-current@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-current
> To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"