From owner-p4-projects@FreeBSD.ORG Thu Jan 17 10:07:21 2008 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 76CE616A420; Thu, 17 Jan 2008 10:07:21 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3CB8616A418 for ; Thu, 17 Jan 2008 10:07:21 +0000 (UTC) (envelope-from scottl@freebsd.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 2A82413C4E3 for ; Thu, 17 Jan 2008 10:07:21 +0000 (UTC) (envelope-from scottl@freebsd.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id m0HA7LtC008874 for ; Thu, 17 Jan 2008 10:07:21 GMT (envelope-from scottl@freebsd.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id m0HA7LE7008871 for perforce@freebsd.org; Thu, 17 Jan 2008 10:07:21 GMT (envelope-from scottl@freebsd.org) Date: Thu, 17 Jan 2008 10:07:21 GMT Message-Id: <200801171007.m0HA7LE7008871@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to scottl@freebsd.org using -f From: Scott Long To: Perforce Change Reviews Cc: Subject: PERFORCE change 133467 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Jan 2008 10:07:21 -0000 http://perforce.freebsd.org/chv.cgi?CH=133467 Change 133467 by scottl@scottl-ix on 2008/01/17 10:07:19 Disable a couple of optimizations that result in traffic stopping on the interface. The netfront/xn driver now seems to work reliably. Affected files ... .. //depot/projects/xen31/sys/dev/xen/netfront/netfront.c#9 edit Differences ... ==== //depot/projects/xen31/sys/dev/xen/netfront/netfront.c#9 (text+ko) ==== @@ -948,11 +948,13 @@ np->rx.rsp_cons = i; +#if 0 /* If we get a callback with very few responses, reduce fill target. */ /* NB. Note exponential increase, linear decrease. */ if (((np->rx.req_prod_pvt - np->rx.sring->rsp_prod) > ((3*np->rx_target) / 4)) && (--np->rx_target < np->rx_min_target)) np->rx_target = np->rx_min_target; +#endif network_alloc_rx_buffers(np); @@ -1039,10 +1041,12 @@ struct netfront_info *np = xsc; struct ifnet *ifp = np->xn_ifp; +#if 0 if (!(np->rx.rsp_cons != np->rx.sring->rsp_prod && likely(netfront_carrier_ok(np)) && ifp->if_drv_flags & IFF_DRV_RUNNING)) return; +#endif if (np->tx.rsp_cons != np->tx.sring->rsp_prod) { XN_TX_LOCK(np); xn_txeof(np);