From owner-cvs-all Thu Sep 13 19:32:16 2001 Delivered-To: cvs-all@freebsd.org Received: from mail.rpi.edu (mail.rpi.edu [128.113.22.40]) by hub.freebsd.org (Postfix) with ESMTP id 5FD3C37B410; Thu, 13 Sep 2001 19:32:09 -0700 (PDT) Received: from [128.113.24.47] (gilead.acs.rpi.edu [128.113.24.47]) by mail.rpi.edu (8.11.3/8.11.3) with ESMTP id f8E2W3U122026; Thu, 13 Sep 2001 22:32:03 -0400 Mime-Version: 1.0 X-Sender: drosih@mail.rpi.edu Message-Id: In-Reply-To: <20010914025459.E29860@tao.org.uk> References: <200109140151.f8E1prd00702@hak.lan.Awfulhak.org> <20010914025459.E29860@tao.org.uk> Date: Thu, 13 Sep 2001 22:32:00 -0400 To: Josef Karthauser , Brian Somers From: Garance A Drosihn Subject: Re: Proposed patch to log_accum.pl Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Content-Type: text/plain; charset="us-ascii" ; format="flowed" Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG At 2:54 AM +0100 9/14/01, Josef Karthauser wrote: > > > I've attached a patch to CVSROOT/log_accum.pl that I'd like comments > > > on before I commit it. Thanks very much for looking into this! I had intended to do it, but I wanted to wait until all your recent flurry of improvements had gone in. > > > At the moment we get a summary line for each modified file in the > > > commit email, i.e.: > > > =20 >> > Revision Changes Path >> > 1.108 +6 -5 src/sys/kern/kern_descrip.c >> > >> > The attached patch caused us to also get these lines for added and > > > removed files. It's been suggested that the revision number be > > > followed with "(dead)" in the case of removed files. Is this > > > necessary? > > >> I think something like: >> >> Revision Changes Path > > 1.108 +6 -5 src/sys/kern/kern_descrip.c >> 1.1 +123 src/sys/kern/new_file.c >> 1.234 -669 src/sys/kern/dead_file.c > > >> is sufficient. > >That makes good sense. Anything else? For parsing purposes, I was thinking of something more like: Revision Changes Path 1.108 +6 -5 src/sys/kern/kern_descrip.c 1.1 +123 0 src/sys/kern/new_file.c (new) 1.234 0 -669 src/sys/kern/dead_file.c (attic) I'd want the same number of columns under "Changes" for those people who parse this by splitting on blanks. And there was some reason I needed an explicit indication of "new" and "removed" files. (I want this for a 'cvsmerge' perl script that I've been working on). Hmm, actually I can tell "new" because the revision number will be 1.1, but it still looks nice to have that '(new)' on the line... -- Garance Alistair Drosehn = gad@eclipse.acs.rpi.edu Senior Systems Programmer or gad@freebsd.org Rensselaer Polytechnic Institute or drosih@rpi.edu To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message