From owner-freebsd-current  Sat Mar 30  1: 5:54 2002
Delivered-To: freebsd-current@freebsd.org
Received: from mailout01.sul.t-online.com (mailout01.sul.t-online.com [194.25.134.80])
	by hub.freebsd.org (Postfix) with ESMTP
	id 9EC6237B416; Sat, 30 Mar 2002 01:05:50 -0800 (PST)
Received: from fwd04.sul.t-online.de 
	by mailout01.sul.t-online.com with smtp 
	id 16rEmI-000150-06; Sat, 30 Mar 2002 10:04:02 +0100
Received: from Magelan.Leidinger.net (520065502893-0001@[217.229.221.66]) by fmrl04.sul.t-online.com
	with esmtp id 16rEmC-2817mCC; Sat, 30 Mar 2002 10:03:56 +0100
Received: from Leidinger.net (netchild@localhost [127.0.0.1])
	by Magelan.Leidinger.net (8.12.2/8.12.2) with ESMTP id g2U93l7S002763;
	Sat, 30 Mar 2002 10:03:51 +0100 (CET)
	(envelope-from netchild@Leidinger.net)
Message-Id: <200203300903.g2U93l7S002763@Magelan.Leidinger.net>
Date: Sat, 30 Mar 2002 10:03:47 +0100 (CET)
From: Alexander Leidinger <Alexander@Leidinger.net>
Subject: Re: cvs commit: ports/lang Makefile ports/lang/icc Makefile distinfo pkg-comment pkg-descr pkg-plist ports/lang/icc/files patch-include
To: obrien@FreeBSD.org
Cc: winter@jurai.net, freebsd-current@FreeBSD.org
In-Reply-To: <20020329202533.B74181@dragon.nuxi.com>
MIME-Version: 1.0
Content-Type: TEXT/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8BIT
X-Sender: 520065502893-0001@t-dialin.net
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-current.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-current>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-current>
X-Loop: FreeBSD.ORG

On 29 Mär, David O'Brien wrote:

>> > My patches to src/share/mk/ are here:
>> > 
>> > 	ftp://ftp.jurai.net/users/winter/icc.mk.diff
>> > 
>> > This allows you to set 'USE_ICC' and 'ICFLAGS' and build stuff.
> 
> This is fine just to get things working.  But please consider Doing It
> Right -- that being wrap the definitions of CC, CFLAGS, and PICFLAG with
> USE_ICC rather than strew USE_ICC all over the place.  For instance:
> 
>     /usr/share/mk/sys.mk
>     .if defined(USE_ICC)
>     CC= icc
>     .else
>     CC= cc
>     .endif

- How do you want to solve the single suffix rules then?
- Do we use ${LD} in every significant place?
- What about ports with "CC=${CC}" in CONFIGURE_ENV (they would break
  in the USE_ICC case)?

>> > -D__ICC__=1
>> 
>> ICC already defines '__ICC', doe we really need this?
> 
> I see no reason for it.  We should use the vendor's spelling for
> identifying their compiler.
>  
>> > -D__attribute__(x)=
>> > -D__GNUC__=2
>> 
>> Ok as a short term solution, but IMHO this should get solved in the
>> source.
> 
> Totally agreed for defining __GNUC__.

And the __attribute__ line is the reason why libc doesn't work.

Bye,
Alexander.

-- 
         The computer revolution is over. The computers won.

http://www.Leidinger.net                       Alexander @ Leidinger.net
  GPG fingerprint = C518 BC70 E67F 143F BE91  3365 79E2 9C60 B006 3FE7


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message