From owner-svn-src-all@FreeBSD.ORG Sat Aug 29 19:47:39 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BDAE61065674; Sat, 29 Aug 2009 19:47:39 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id AC8408FC14; Sat, 29 Aug 2009 19:47:39 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id n7TJldHD073103; Sat, 29 Aug 2009 19:47:39 GMT (envelope-from dougb@svn.freebsd.org) Received: (from dougb@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id n7TJldIb073101; Sat, 29 Aug 2009 19:47:39 GMT (envelope-from dougb@svn.freebsd.org) Message-Id: <200908291947.n7TJldIb073101@svn.freebsd.org> From: Doug Barton Date: Sat, 29 Aug 2009 19:47:39 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-7@freebsd.org X-SVN-Group: stable-7 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r196646 - stable/7/etc X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 29 Aug 2009 19:47:39 -0000 Author: dougb Date: Sat Aug 29 19:47:39 2009 New Revision: 196646 URL: http://svn.freebsd.org/changeset/base/196646 Log: MFC 196478: Prior to the dire warning about values of network_interfaces other than AUTO the biggest mistake users made was leaving lo0 off the list. Since lo0 is effectively mandatory, check for it and add it to the list if it's not there. MFC 196523: Improve the case test to detect the presence of lo0 in the list of network_interfaces. Submitted by: Christoph Mallon Modified: stable/7/etc/ (props changed) stable/7/etc/network.subr stable/7/etc/termcap.small (props changed) Modified: stable/7/etc/network.subr ============================================================================== --- stable/7/etc/network.subr Sat Aug 29 19:45:03 2009 (r196645) +++ stable/7/etc/network.subr Sat Aug 29 19:47:39 2009 (r196646) @@ -643,6 +643,13 @@ list_net_interfaces() "AUTO are deprecated" fi _tmplist="${network_interfaces} ${cloned_interfaces}" + + # lo0 is effectively mandatory, so help prevent foot-shooting + # + case "$_tmplist" in + lo0|'lo0 '*|*' lo0'|*' lo0 '*) ;; # This is fine, do nothing + *) _tmplist="lo0 ${_tmplist}" ;; + esac ;; esac