From owner-svn-src-stable@FreeBSD.ORG  Wed Feb 18 16:28:56 2015
Return-Path: <owner-svn-src-stable@FreeBSD.ORG>
Delivered-To: svn-src-stable@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 2FBF8FA0;
 Wed, 18 Feb 2015 16:28:56 +0000 (UTC)
Received: from svn.freebsd.org (svn.freebsd.org
 [IPv6:2001:1900:2254:2068::e6a:0])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 174CCF97;
 Wed, 18 Feb 2015 16:28:56 +0000 (UTC)
Received: from svn.freebsd.org ([127.0.1.70])
 by svn.freebsd.org (8.14.9/8.14.9) with ESMTP id t1IGSt9E070096;
 Wed, 18 Feb 2015 16:28:55 GMT (envelope-from sbruno@FreeBSD.org)
Received: (from sbruno@localhost)
 by svn.freebsd.org (8.14.9/8.14.9/Submit) id t1IGSt1J070095;
 Wed, 18 Feb 2015 16:28:55 GMT (envelope-from sbruno@FreeBSD.org)
Message-Id: <201502181628.t1IGSt1J070095@svn.freebsd.org>
X-Authentication-Warning: svn.freebsd.org: sbruno set sender to
 sbruno@FreeBSD.org using -f
From: Sean Bruno <sbruno@FreeBSD.org>
Date: Wed, 18 Feb 2015 16:28:55 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org
Subject: svn commit: r278961 - stable/10/usr.sbin/binmiscctl
X-SVN-Group: stable-10
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-stable@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for all the -stable branches of the src tree
 <svn-src-stable.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-stable>,
 <mailto:svn-src-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-stable/>
List-Post: <mailto:svn-src-stable@freebsd.org>
List-Help: <mailto:svn-src-stable-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-stable>,
 <mailto:svn-src-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 18 Feb 2015 16:28:56 -0000

Author: sbruno
Date: Wed Feb 18 16:28:55 2015
New Revision: 278961
URL: https://svnweb.freebsd.org/changeset/base/278961

Log:
  MFC r278827
  
  Check for required arguments before accessing argv[0] and core dumping.

Modified:
  stable/10/usr.sbin/binmiscctl/binmiscctl.c
Directory Properties:
  stable/10/   (props changed)

Modified: stable/10/usr.sbin/binmiscctl/binmiscctl.c
==============================================================================
--- stable/10/usr.sbin/binmiscctl/binmiscctl.c	Wed Feb 18 15:25:25 2015	(r278960)
+++ stable/10/usr.sbin/binmiscctl/binmiscctl.c	Wed Feb 18 16:28:55 2015	(r278961)
@@ -371,8 +371,10 @@ add_cmd(__unused int argc, char *argv[],
 }
 
 int
-name_cmd(__unused int argc, char *argv[], ximgact_binmisc_entry_t *xbe)
+name_cmd(int argc, char *argv[], ximgact_binmisc_entry_t *xbe)
 {
+	if (argc == 0)
+		usage("Required argument missing\n");
 	if (strlen(argv[0]) > IBE_NAME_MAX)
 		usage("'%s' string length longer than IBE_NAME_MAX (%d)",
 		    IBE_NAME_MAX);