From owner-freebsd-ports-bugs@FreeBSD.ORG Sat May 2 21:52:28 2015 Return-Path: Delivered-To: freebsd-ports-bugs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 31CCF2FC for ; Sat, 2 May 2015 21:52:28 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1B68F1A2C for ; Sat, 2 May 2015 21:52:28 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t42LqRg9084729 for ; Sat, 2 May 2015 21:52:27 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 199503] [PATCH] games/oolite: Convert to USES=gnustep Date: Sat, 02 May 2015 21:52:28 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: lightside@gmx.com X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: maintainer-feedback+ X-Bugzilla-Changed-Fields: attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 May 2015 21:52:28 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=199503 --- Comment #3 from lightside --- Created attachment 156254 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=156254&action=edit Proposed patch (second variant, since 383856 revision) In my opinion, the issue with new Mk/Uses/gnustep.mk file is related to regression category, because of: - Removal of some defines used by ports, e.g. GNUSTEP_LOCAL_APPS in this case - Overriding of MAKEFILE variable to different value, without possibility to change it, e.g. with USE_MAKEFILE define in this case I don't know, whether this will be fixed or not. Nevertheless, there is a workaround on games/oolite port level: - Add correct GNUSTEP_LOCAL_APPS define - Override DO_MAKE_BUILD variable, which used on do-build stage, e.g. use (default) Makefile instead of ${MAKEFILE} define I attached the second variant of the proposed patch. It doesn't require approval from ports manager, I guess. To Andriy Gapon (avg@, maintainer): What do you think, which variant of the proposed patch should be used for commit? -- You are receiving this mail because: You are the assignee for the bug.