From owner-freebsd-hackers@FreeBSD.ORG Tue Nov 9 16:43:18 2010 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C7F39106566B; Tue, 9 Nov 2010 16:43:18 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-iw0-f182.google.com (mail-iw0-f182.google.com [209.85.214.182]) by mx1.freebsd.org (Postfix) with ESMTP id 6E0C48FC15; Tue, 9 Nov 2010 16:43:18 +0000 (UTC) Received: by iwn39 with SMTP id 39so7821114iwn.13 for ; Tue, 09 Nov 2010 08:43:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:sender:received :in-reply-to:references:date:x-google-sender-auth:message-id:subject :from:to:cc:content-type; bh=CxWAqCkywN3nF/ZZPkHFn+Ognr6wsh+CTcLBxt+ruwg=; b=YUI6ZIhLz346kgzvqRwOSQVqO9WOmFHzSiyeWUemhE/d2H3fqDo2Ox20Uu0aL+ZKgX Im4uJ/AS05gvpyNoOJYEh0g+A0mK6v/n+P3igekXxV8gLwSWoBcnmHPSlx4m1IZeF9Bb X+24ZgoH1PuCZviBuGZsjEnUR9W9zh7Mx0oG4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; b=NoFTdGUGHv9z2Z0CdX/hBzLEly0Xlgqpe/bdmT6Y1VrN9RrKAko/VU8lOCC2AfICID s+CRTz1g9Vp30Zu9H5s7AIz7nbH0MxqUJShXHFpE41r2LngHtYN5YiYKS8mg7b4eHxS8 fJW7QAkrsPgvriUswBUTiaIUaSsM3sSCsFx2w= MIME-Version: 1.0 Received: by 10.231.169.135 with SMTP id z7mr5441867iby.28.1289320996760; Tue, 09 Nov 2010 08:43:16 -0800 (PST) Sender: baptiste.daroussin@gmail.com Received: by 10.231.180.164 with HTTP; Tue, 9 Nov 2010 08:43:16 -0800 (PST) In-Reply-To: References: <20101106120752.001e92c0@ernst.jennejohn.org> <86vd4ao5o4.fsf@gmail.com> Date: Tue, 9 Nov 2010 17:43:16 +0100 X-Google-Sender-Auth: EQ6vT3m8V_urCIJEbYahgPOlLiY Message-ID: From: Baptiste Daroussin To: Ade Lovett Content-Type: text/plain; charset=ISO-8859-1 Cc: Anonymous , freebsd-hackers@freebsd.org, freebsd-arch@freebsd.org Subject: Re: [PATCH] update to the latest libedit version and remove libreadline deps X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Nov 2010 16:43:18 -0000 Yet another version of the patch, I hope the last one http://people.freebsd.org/~bapt/update-libedit.patch Everything should be working as it used to do before. Now gdbtui is almost working. why almost because everything works except Ctrl-D (EOF), I know where the bug is (lib/libedit/read.c : function: FUN(el,gets)(EditLine *el, int *nread), the read pb is in readchar I guess) but I can't find a way to fix it and it seems to me a really minor regression. I think we can live with this as this bug appear only when libedit doesn't directly gets its input but get is through a third party interface (ncurses in that case) and gdbtui is the only program in base working like this. Also thanks for the information about exp-run, if anyone is about to accept this patch and wanted to commit it, I'll follow those informations. regards, Bapt