From owner-svn-src-all@FreeBSD.ORG Mon Mar 31 04:25:45 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 5C7BEF93; Mon, 31 Mar 2014 04:25:45 +0000 (UTC) Received: from mail-pa0-x236.google.com (mail-pa0-x236.google.com [IPv6:2607:f8b0:400e:c03::236]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1DDCD346; Mon, 31 Mar 2014 04:25:45 +0000 (UTC) Received: by mail-pa0-f54.google.com with SMTP id lf10so7657229pab.13 for ; Sun, 30 Mar 2014 21:25:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:date:to:cc:subject:message-id:reply-to:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=rHdcdKRCTQJ5W+yF41MLiZcsxANoqSWAReL1Jh3FEYg=; b=O3pKoTgOuHl3SQV7iouB+Xih+acl9ai582ZmILyR+eQ8+gTXTy7zV0NS4A4c5QQcZY /hygRl669pH6qeslfPiLCoNYQIy8nQhH7gd7t3xE3/qme4xG/11i987d5z8Qcxsp3cRp DKK/2iDloz1/q7QiUJ1pHBwmAO/eb6IhOfHEnEyhprHjOtxppop5YKG9c8zQwdlV/BSd x95Rmmu23GBW94EscpDfJxz6Eqbye7oYZVfK2ES1qNEodxnmRE2A84xDEx9FnNqJWKQs oX0JZkwCWnc+J7T4wdT9AEoKFBZNO/Ubt/mw8B/bgMc6rnz7eaqhzXen0vK9dS9lIzoa IGsA== X-Received: by 10.68.237.133 with SMTP id vc5mr22665457pbc.92.1396239944742; Sun, 30 Mar 2014 21:25:44 -0700 (PDT) Received: from pyunyh@gmail.com (lpe4.p59-icn.cdngp.net. [114.111.62.249]) by mx.google.com with ESMTPSA id lh13sm34523855pab.4.2014.03.30.21.25.41 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Sun, 30 Mar 2014 21:25:43 -0700 (PDT) Received: by pyunyh@gmail.com (sSMTP sendmail emulation); Mon, 31 Mar 2014 13:25:35 +0900 From: Yonghyeon PYUN Date: Mon, 31 Mar 2014 13:25:35 +0900 To: John-Mark Gurney Subject: Re: svn commit: r263957 - in head/sys: dev/age dev/alc dev/ale dev/bce dev/bge dev/fxp dev/jme dev/msk dev/nfe dev/sge pci Message-ID: <20140331042535.GA1359@michelle.cdnetworks.com> References: <201403310154.s2V1sxXY010836@svn.freebsd.org> <20140331040058.GV60889@funkthat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140331040058.GV60889@funkthat.com> User-Agent: Mutt/1.4.2.3i Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Pyun YongHyeon X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list Reply-To: pyunyh@gmail.com List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Mar 2014 04:25:45 -0000 On Sun, Mar 30, 2014 at 09:00:59PM -0700, John-Mark Gurney wrote: > Pyun YongHyeon wrote this message on Mon, Mar 31, 2014 at 01:54 +0000: > > Author: yongari > > Date: Mon Mar 31 01:54:59 2014 > > New Revision: 263957 > > URL: http://svnweb.freebsd.org/changeset/base/263957 > > > > Log: > > Increase the number of TX DMA segments from 32 to 35. It turned > > out 32 is not enough to support a full sized TSO packet. > > While I'm here fix a long standing bug introduced in r169632 in > > bce(4) where it didn't include L2 header length of TSO packet in > > the maximum DMA segment size calculation. > > I assume all of the hardware supports this increase? > Yes. Data sheet does not mention about such limitation. txp(4) has a limitation on the number of TX segments but I didn't implement TSO in txp(4). > Also, is there a reason to only increase up to 35 and not something > larger, like 64? Is there a memory or performance penalty? > If 64 does not overflow kernel stack we can also bump the number to 64.