From owner-svn-ports-all@FreeBSD.ORG Tue Dec 10 16:54:12 2013 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id EA111D56; Tue, 10 Dec 2013 16:54:11 +0000 (UTC) Received: from mail-la0-x22e.google.com (mail-la0-x22e.google.com [IPv6:2a00:1450:4010:c03::22e]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id ADB961CED; Tue, 10 Dec 2013 16:54:10 +0000 (UTC) Received: by mail-la0-f46.google.com with SMTP id eh20so2919767lab.19 for ; Tue, 10 Dec 2013 08:54:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=W4ZeQF9SS2MVYHszky8axOqAhgNGAU/TQmy0+ejPSk4=; b=jHMA27VzTyzmz58WxUdYQdc1IYN6tUDJ2n9JGTqM6zCvwPypCPCJHos9ujPZyGz0aa gXuHSkmGQ6eUTWZelDkqVTP1A3xKmLQV0UIWxZ77AIpeFoGb29/scQEG0RboGlN6Chgc rbXbZzF2Jx3JKIvdMbakfXVKlsLfoFGVLP9e6hmh527rZ4HiXBGd+Wi/tcBQfLKQ6Bfj USwhjq+yphW+K9pG7QTV8mKU9wRe+pbej4CLKGCRUWTtFRIWu7yIpVmK2/8ppP4PmH0v pfvCmr1Hjcv9xNpH5ccq1djXEVQviQTsPHISJwyJxMUnG5d2+hqbdyWg2BuQISnxYRk2 lnwA== X-Received: by 10.152.9.193 with SMTP id c1mr5827938lab.53.1386694448287; Tue, 10 Dec 2013 08:54:08 -0800 (PST) Received: from [192.168.77.101] (mail1.amcu.gov.ua. [213.160.139.2]) by mx.google.com with ESMTPSA id xl4sm22891533lac.9.2013.12.10.08.54.04 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 10 Dec 2013 08:54:05 -0800 (PST) Message-ID: <52A7471E.6080109@gmail.com> Date: Tue, 10 Dec 2013 18:53:50 +0200 From: Kozlov Sergey User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.1.1 MIME-Version: 1.0 To: Gerald Pfeifer Subject: Re: svn commit: r335189 - in head/print/pdftk: . files References: <201311291548.rATFm8g7098382@svn.freebsd.org> <529C7599.1050509@gmail.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Mathieu Arnold , Greg Larkin , svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Dec 2013 16:54:12 -0000 On 08.12.2013 23:39, Gerald Pfeifer wrote: > On Mon, 2 Dec 2013, Kozlov Sergey wrote: > >> 1. GCC does not always come with gcj, user can compile the port without >> it. So pdftk needs both gcc and gcj to build, and they are added >> explicitly as build dependencies. > Except that this won't work. If USE_GCC=yes did not already include > GCJ, then just rebuilding the port, with the same (saved) options will > not make a difference. Yes, that's correct. I think the right solution is to add a check if gcj is present and give an IGNORE with suggestion to rebuild gcc. > LIB_DEPENDS= libgcj.so:${PORTSDIR}/lang/gcc${CSUFF} \ > libstdc++.so:${PORTSDIR}/lang/gcc${CSUFF} \ > libgcc_s.so:${PORTSDIR}/lang/gcc${CSUFF} > > If you insist on libgcj.so, I can accept that, but then let's drop > the other two least. This is definitely covered by USE_GCC=yes. USE_GCC doesn't add anything to RUN_DEPENDS. When I got the problem with uninstalling gcc and making pdftk not work I used the ldd on pdftk and got the following: root@fbsd10-test:/usr/ports/print/pdftk # ldd /usr/local/bin/pdftk /usr/local/bin/pdftk: libgcj.so.12 => /usr/local/lib/gcc46/libgcj.so.12 (0x800a8a000) libz.so.6 => /lib/libz.so.6 (0x803cdb000) libstdc++.so.6 => /usr/local/lib/gcc46/libstdc++.so.6 (0x803ef0000) libm.so.5 => /lib/libm.so.5 (0x8041f4000) libgcc_s.so.1 => /usr/local/lib/gcc46/libgcc_s.so.1 (0x80441a000) libthr.so.3 => /lib/libthr.so.3 (0x80462f000) libc.so.7 => /lib/libc.so.7 (0x804854000) librt.so.1 => /usr/lib/librt.so.1 (0x804bed000) I saw 3 libs provided by gcc so I added them all to LIB_DEPENDS I understand that if libgcj is provided then libstdc++ and libgcc_s is surely provided as well, and I don't know what is the right decision in these circumstances. > BUILD_DEPENDS=gcj${CSUFF}:${PORTSDIR}/lang/gcc${CSUFF} \ > gcjh${CSUFF}:${PORTSDIR}/lang/gcc${CSUFF} \ > cpp${CSUFF}:${PORTSDIR}/lang/gcc${CSUFF} > > And here just pick one of gcj or gcjh, that is sufficient and in > line what we usually do. > > And remove the dependency on cpp, since again this is covered by > USE_GCC=yes. The same situation as with LIB_DEPENDS. I don't know what to do if one dependency is surely provided by another one. > > Can I go ahead and just make that > > LIB_DEPENDS= libgcj.so:${PORTSDIR}/lang/gcc${CSUFF} > BUILD_DEPENDS= gcj${CSUFF}:${PORTSDIR}/lang/gcc${CSUFF} > > ? > > Gerald Generally speaking, I think that's ok but we should really hear the opinion of port's maintainer. Best regards, Kozlov Sergey.