From owner-freebsd-mips@FreeBSD.ORG  Sat Feb  6 03:05:17 2010
Return-Path: <owner-freebsd-mips@FreeBSD.ORG>
Delivered-To: freebsd-mips@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 5FB69106566B
	for <freebsd-mips@FreeBSD.org>; Sat,  6 Feb 2010 03:05:17 +0000 (UTC)
	(envelope-from imp@bsdimp.com)
Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85])
	by mx1.freebsd.org (Postfix) with ESMTP id 23DAA8FC12
	for <freebsd-mips@FreeBSD.org>; Sat,  6 Feb 2010 03:05:17 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
	by harmony.bsdimp.com (8.14.3/8.14.1) with ESMTP id o1630aUo039098;
	Fri, 5 Feb 2010 20:00:36 -0700 (MST) (envelope-from imp@bsdimp.com)
Date: Fri, 05 Feb 2010 20:01:34 -0700 (MST)
Message-Id: <20100205.200134.460114267490858629.imp@bsdimp.com>
To: neelnatu@gmail.com
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <dffe84831002051827r430c7fb6le3c3506bd6d38a03@mail.gmail.com>
References: <dffe84831002051827r430c7fb6le3c3506bd6d38a03@mail.gmail.com>
X-Mailer: Mew version 6.3 on Emacs 22.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: freebsd-mips@FreeBSD.org
Subject: Re: Patch: SMP support for MIPS
X-BeenThere: freebsd-mips@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting FreeBSD to MIPS <freebsd-mips.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-mips>,
	<mailto:freebsd-mips-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-mips>
List-Post: <mailto:freebsd-mips@freebsd.org>
List-Help: <mailto:freebsd-mips-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-mips>,
	<mailto:freebsd-mips-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 06 Feb 2010 03:05:17 -0000

In message: <dffe84831002051827r430c7fb6le3c3506bd6d38a03@mail.gmail.com>
            Neel Natu <neelnatu@gmail.com> writes:
: I have put the diff here for review:
: http://people.freebsd.org/~neel/mips_smp_patch/diff.txt

+ /*
+  * XXX
+   * SMP kernels must delay pcpu initialization until after
+    * TLB has been flushed and initialized (see mips_cpu_init())
+     */
+     if (pcpu_find(0) == NULL)
+     	 mips_pcpu0_init();
+

The practical upshot of this change is that panic() prior to this
point will fault.  Is there some way to avoid this?

The rest of these changes look fairly good.  I'll likely comment on a
few nits later that I saw once I have the time to devote to it.

Warner