From owner-cvs-src@FreeBSD.ORG Sun Aug 17 20:02:56 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1BF5837B401; Sun, 17 Aug 2003 20:02:56 -0700 (PDT) Received: from dragon.nuxi.com (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id 553C043FA3; Sun, 17 Aug 2003 20:02:53 -0700 (PDT) (envelope-from obrien@NUXI.com) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by dragon.nuxi.com (8.12.9/8.12.9) with ESMTP id h7I32qQX058615; Sun, 17 Aug 2003 20:02:52 -0700 (PDT) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.12.9/8.12.9/Submit) id h7I32pBA058614; Sun, 17 Aug 2003 20:02:51 -0700 (PDT) Date: Sun, 17 Aug 2003 20:02:51 -0700 From: "David O'Brien" To: Bruce Evans Message-ID: <20030818030251.GA58592@dragon.nuxi.com> References: <200308180036.h7I0aVFl033156@repoman.freebsd.org> <20030818122222.S82619@gamplex.bde.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030818122222.S82619@gamplex.bde.org> User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD 5.1-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/etc Makefile src/etc/isdn Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Aug 2003 03:02:56 -0000 On Mon, Aug 18, 2003 at 12:34:50PM +1000, Bruce Evans wrote: > On Sun, 17 Aug 2003, David E. O'Brien wrote: > > Modified files: > > etc Makefile > > etc/isdn Makefile > > Log: > > Don't hardcode owner 'root' and group 'wheel'. > > > > Submitted by: Ulrich Spoerlein > > This needs more thought. The owner was hardcoded to root for ppp at > least for much the same reason that the owner of the ppp binary and > all (?) other setuid binaries is forced to be root: only root should > be able to read it. The ownership shouldn't be hard-coded, but it > shouldn't be ${BINOWN}:${BINGRP} either, so that overriding the defaults > for BINOWN and BINGRP doesn't automatically open security holes. At this point I don't think we can safely set BINOWN to anything other than 'root'. This isn't the first Makefile to assume BINOWN was root from a security POV. -- -- David (obrien@FreeBSD.org)