From owner-freebsd-bugs@FreeBSD.ORG  Fri May 31 15:10:01 2013
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@smarthost.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id A74855B8
 for <freebsd-bugs@smarthost.ysv.freebsd.org>;
 Fri, 31 May 2013 15:10:01 +0000 (UTC)
 (envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by mx1.freebsd.org (Postfix) with ESMTP id 997FF9A3
 for <freebsd-bugs@smarthost.ysv.freebsd.org>;
 Fri, 31 May 2013 15:10:01 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
 by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id r4VFA1uO076539
 for <freebsd-bugs@freefall.freebsd.org>; Fri, 31 May 2013 15:10:01 GMT
 (envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
 by freefall.freebsd.org (8.14.7/8.14.7/Submit) id r4VFA1Cq076538;
 Fri, 31 May 2013 15:10:01 GMT (envelope-from gnats)
Date: Fri, 31 May 2013 15:10:01 GMT
Message-Id: <201305311510.r4VFA1Cq076538@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
Cc: 
From: Mark Johnston <markj@freebsd.org>
Subject: Re: bin/179122: [patch] Fix bug with newsyslog -t
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
Reply-To: Mark Johnston <markj@freebsd.org>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 31 May 2013 15:10:01 -0000

The following reply was made to PR bin/179122; it has been noted by GNATS.

From: Mark Johnston <markj@freebsd.org>
To: Oliver Fromme <olli@grabthar.secnetix.de>
Cc: Oliver Fromme <olli@secnetix.de>, bug-followup@freebsd.org
Subject: Re: bin/179122: [patch] Fix bug with newsyslog -t
Date: Fri, 31 May 2013 11:06:29 -0400

 On Fri, May 31, 2013 at 10:40:32AM +0200, Oliver Fromme wrote:
 > Hi Mark,
 > 
 >  > Thanks for reporting this. I've done some testing and the patch looks
 >  > correct. Have you configured the log file in question to be rotated once
 >  > every hour? If not, then newsyslog -t wouldn't have been working
 >  > properly before either.
 > 
 > No, this is with the default newsyslog.conf of a fresh
 > installation.
 > 
 > I've been using -a and -t together on a different machine
 > with an older version of stable/9 (about half a year old),
 > and I never got any such error messages from newsyslog
 > there.  However, I did not verify that the rotation
 > really worked correctly ...  I assumed it did.  I only
 > started to look more closely now that I got those error
 > messages with the recent version of stable/9.
 
 newsyslog -t has never worked properly for rotating logfiles based on
 mtimes; my fix tried to address that, but as you noticed, there is a
 problem. :)
 
 Aside from the error messages, the behaviour of newsyslog in your case
 will be the same as before. I will commit your patch later today.
 
 Thanks again,
 -Mark