From owner-freebsd-multimedia@FreeBSD.ORG Fri Jul 15 10:48:12 2011 Return-Path: Delivered-To: freebsd-multimedia@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 694D1106566C; Fri, 15 Jul 2011 10:48:12 +0000 (UTC) (envelope-from alexander@leidinger.net) Received: from mail.ebusiness-leidinger.de (mail.ebusiness-leidinger.de [217.11.53.44]) by mx1.freebsd.org (Postfix) with ESMTP id 145138FC17; Fri, 15 Jul 2011 10:48:11 +0000 (UTC) Received: from outgoing.leidinger.net (p4FC4368C.dip.t-dialin.net [79.196.54.140]) by mail.ebusiness-leidinger.de (Postfix) with ESMTPSA id 3EE5484401B; Fri, 15 Jul 2011 12:30:06 +0200 (CEST) Received: from webmail.leidinger.net (webmail.Leidinger.net [IPv6:fd73:10c7:2053:1::3:102]) by outgoing.leidinger.net (Postfix) with ESMTP id 77CFE2105; Fri, 15 Jul 2011 12:30:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=Leidinger.net; s=outgoing-alex; t=1310725803; bh=w9IOdyx4uoOCfvRthvr+TLxjrKPs5UQ+Ttb44leVJZk=; h=Message-ID:Date:From:To:Cc:Subject:References:In-Reply-To: MIME-Version:Content-Type:Content-Transfer-Encoding; b=JZqv6o5buOn3SeDv++/r8yhfOyT03fh6IdqCDDtKEMpwwpMVt3jIB9zzGItoM3kXY IpAPwq9rIcVR+9UYmJNpTBl2PJDwB7eOIbTJj7B//befR2jSEgz54+IcKQ//OTeeQ9 F2BVaJg+F74RL2LHEO4uo10B9OFP9KtDnsAm+axPOA4e3U1y+GAm8sTfhLDpElGPtG QozsvaQWxx/rfzqzLtxtghWmIkix1mNGsZ7mcP1RBwWwtNf61ZDE6TlHG8m2CO3uK1 qISpm6ST1CC6CtPNGddPj1Q9Daq4ubqcYEBvrJtAENPHCeavI7rynRdFJq8EljJflP pinTnYfWEpSxQ== Received: (from www@localhost) by webmail.leidinger.net (8.14.4/8.14.4/Submit) id p6FAU2P9018736; Fri, 15 Jul 2011 12:30:02 +0200 (CEST) (envelope-from Alexander@Leidinger.net) X-Authentication-Warning: webmail.leidinger.net: www set sender to Alexander@Leidinger.net using -f Received: from 62.72.127.66 ([62.72.127.66]) by webmail.leidinger.net (Horde Framework) with HTTP; Fri, 15 Jul 2011 12:30:02 +0200 Message-ID: <20110715123002.363272dtl9b48dka@webmail.leidinger.net> Date: Fri, 15 Jul 2011 12:30:02 +0200 From: Alexander Leidinger To: Juergen Lock References: <20110714205415.GA3304@triton8.kn-bremen.de> In-Reply-To: <20110714205415.GA3304@triton8.kn-bremen.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; DelSp="Yes"; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: 7bit User-Agent: Dynamic Internet Messaging Program (DIMP) H3 (1.1.6) X-EBL-MailScanner-Information: Please contact the ISP for more information X-EBL-MailScanner-ID: 3EE5484401B.A127D X-EBL-MailScanner: Found to be clean X-EBL-MailScanner-SpamCheck: not spam, spamhaus-ZEN, SpamAssassin (not cached, score=-0.1, required 6, autolearn=disabled, DKIM_SIGNED 0.10, DKIM_VALID -0.10, DKIM_VALID_AU -0.10) X-EBL-MailScanner-From: alexander@leidinger.net X-EBL-MailScanner-Watermark: 1311330606.91892@mF144KI+HGNU5PIs9psjvw X-EBL-Spam-Status: No Cc: freebsd-multimedia@FreeBSD.org, itetcu@FreeBSD.org Subject: Re: Fixing skype multimedia/linux_v4l2wrapper dependency on 8 X-BeenThere: freebsd-multimedia@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Multimedia discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jul 2011 10:48:12 -0000 Quoting Juergen Lock (from Thu, 14 Jul 2011 22:54:15 +0200): > Installing the skype ports with VIDEO knob on currently fails on > up-to-date stable/8 because the multimedia/linux_v4l2wrapper port > now detects it is not needed anymore (my patch has been committed > to stable a while ago.) So I now made a patch that extracts the > check whether the code is in the kernel into a seperate Makefile.sub > that Linux ports that need V4L2 can include, and changed the skype > ports to do just that. Does this look good and ok to commit? > Index: multimedia/linux_v4l2wrapper-kmod/Makefile.sub > @@ -0,0 +1,12 @@ > +# $FreeBSD$ > + > +# try to avoid child processes when finding out if already in the kernel > +.if ${OSVERSION} > 900036 || (${OSVERSION} < 900000 && ${OSVERSION} > > 802508) > +LINUX_V4L2_INBASE= 1 Here you say that it can be used, even if it is not compiled in and not loaded. > +.else > +.if ${OSVERSION} == 900036 || ${OSVERSION} == 802508 > +LINUX_V4L2_INBASE!= ($(SYSCTL) -n kern.features.linuxulator_v4l2 > 2>/dev/null || true) Here you say it can only be used *if it is loaded or compiled in*. The correct name for the variable here would be LINUX_V4L2_INMEMORY. If it is intended to have a variable which denotes both cases, I would use a different name, maybe ..._OK or ..._AVAILABLE or something similar. > +.else > +LINUX_V4L2_INBASE= 0 > +.endif > +.endif Bye, Alexander. -- The Constitution may not be perfect, but it's a lot better than what we've got! http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137