From owner-svn-src-head@FreeBSD.ORG  Mon Dec 31 21:54:13 2012
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
 by hub.freebsd.org (Postfix) with ESMTP id 9691F851;
 Mon, 31 Dec 2012 21:54:13 +0000 (UTC)
 (envelope-from andrew@fubar.geek.nz)
Received: from smtp-out3.electric.net (smtp-out3.electric.net [72.35.12.188])
 by mx1.freebsd.org (Postfix) with ESMTP id 6A5478FC0A;
 Mon, 31 Dec 2012 21:54:12 +0000 (UTC)
Received: from [204.11.168.155] (helo=securemail.onebox.com)
 by yugo.electric.net with esmtp (Exim 4.77)
 (envelope-from <andrew@fubar.geek.nz>)
 id 1TpnJ8-00067o-Ti; Mon, 31 Dec 2012 13:54:06 -0800
Received: from localhost (unverified [49.226.8.148]) by securemail.onebox.com
 (Rockliffe SMTPRA 9.3.1) with ESMTP id
 <B0089381687@securemail.onebox.com>; Mon, 31 Dec 2012 16:54:06 -0500
Date: Tue, 1 Jan 2013 10:53:53 +1300
From: Andrew Turner <andrew@fubar.geek.nz>
To: Oleksandr Tymoshenko <gonzo@FreeBSD.org>
Subject: Re: svn commit: r244914 - in head/sys/arm: arm include ti/omap4
Message-ID: <20130101105353.14492943@fubar.geek.nz>
In-Reply-To: <201212312119.qBVLJi3V009555@svn.freebsd.org>
References: <201212312119.qBVLJi3V009555@svn.freebsd.org>
Organization: SMTP: smtp.paradise.net.nz
X-Mailer: Claws Mail 3.8.0 (GTK+ 2.24.6; i386-portbld-freebsd8.1)
X-Pirate: Arrrr
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 31 Dec 2012 21:54:13 -0000

On Mon, 31 Dec 2012 21:19:44 +0000 (UTC)
Oleksandr Tymoshenko <gonzo@FreeBSD.org> wrote:
> Modified: head/sys/arm/arm/pl310.c
> ==============================================================================
> --- head/sys/arm/arm/pl310.c	Mon Dec 31 21:09:39 2012
> (r244913) +++ head/sys/arm/arm/pl310.c	Mon Dec 31 21:19:44
...
> @@ -157,29 +131,46 @@ pl310_wait_background_op(uint32_t off, u
>  static __inline void
>  pl310_cache_sync(void)
>  {
> -	pl310_write4(PL310_CACHE_SYNC, 0);
> +	if ((pl310_softc == NULL) || !pl310_softc->sc_enabled)
> +		return;
> +
> +#ifdef PL310_ERRATA_753970
> +	/* Write uncached PL310 register */
> +	pl310_write4(pl310_softc, 0x740, 0xffffffff);
> +#else
> +	pl310_write4(pl310_softc, PL310_CACHE_SYNC, 0xffffffff);
> +#endif
>  }

How hard would it be to detect if we need this errata at boot? From the
errata document it appears to only be present in the r3p0 revision of
the controller. We can then do something like:

#ifdef PL310_ERRATA_753970
	if (errata_753970)
		pl310_write4(pl310_softc, 0x740, 0xffffffff);
	else
#endif
	pl310_write4(pl310_softc, PL310_CACHE_SYNC, 0xffffffff);


Andrew