From owner-svn-src-head@FreeBSD.ORG  Fri Feb 27 14:17:14 2009
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 67942106564A;
	Fri, 27 Feb 2009 14:17:14 +0000 (UTC) (envelope-from bz@FreeBSD.org)
Received: from mail.cksoft.de (mail.cksoft.de [62.111.66.27])
	by mx1.freebsd.org (Postfix) with ESMTP id 1CDAD8FC12;
	Fri, 27 Feb 2009 14:17:14 +0000 (UTC) (envelope-from bz@FreeBSD.org)
Received: from localhost (amavis.str.cksoft.de [192.168.74.71])
	by mail.cksoft.de (Postfix) with ESMTP id 4D63041C69F;
	Fri, 27 Feb 2009 15:17:13 +0100 (CET)
X-Virus-Scanned: amavisd-new at cksoft.de
Received: from mail.cksoft.de ([62.111.66.27])
	by localhost (amavis.str.cksoft.de [192.168.74.71]) (amavisd-new,
	port 10024)
	with ESMTP id R0c4mhxJ2wPk; Fri, 27 Feb 2009 15:17:12 +0100 (CET)
Received: by mail.cksoft.de (Postfix, from userid 66)
	id EDCAE41C679; Fri, 27 Feb 2009 15:17:12 +0100 (CET)
Received: from maildrop.int.zabbadoz.net (maildrop.int.zabbadoz.net
	[10.111.66.10])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mail.int.zabbadoz.net (Postfix) with ESMTP id 3522E4448E6;
	Fri, 27 Feb 2009 14:16:28 +0000 (UTC)
Date: Fri, 27 Feb 2009 14:16:28 +0000 (UTC)
From: "Bjoern A. Zeeb" <bz@FreeBSD.org>
X-X-Sender: bz@maildrop.int.zabbadoz.net
To: src-committers@freebsd.org, svn-src-all@freebsd.org, 
	svn-src-head@freebsd.org
In-Reply-To: <200902271412.n1REC5JD072503@svn.freebsd.org>
Message-ID: <20090227141248.E53478@maildrop.int.zabbadoz.net>
References: <200902271412.n1REC5JD072503@svn.freebsd.org>
X-OpenPGP-Key: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: 
Subject: Re: svn commit: r189106 - in head/sys: compat/linprocfs compat/linux
 compat/svr4 contrib/altq/altq contrib/pf/net dev/cxgb/ulp/iw_cxgb kern net
 net80211 netgraph netgraph/atm netinet netinet6 netipsec ...
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Feb 2009 14:17:14 -0000

On Fri, 27 Feb 2009, Bjoern A. Zeeb wrote:

> Author: bz
> Date: Fri Feb 27 14:12:05 2009
> New Revision: 189106
> URL: http://svn.freebsd.org/changeset/base/189106
>
> Log:
>  For all files including net/vnet.h directly include opt_route.h and
>  net/route.h.
>
>  Remove the hidden include of opt_route.h and net/route.h from net/vnet.h.
>
>  We need to make sure that both opt_route.h and net/route.h are included
>  before net/vnet.h because of the way MRT figures out the number of FIBs
>  from the kernel option. If we do not, we end up with the default number
>  of 1 when including net/vnet.h and array sizes are wrong.
>
>  This does not change the list of files which depend on opt_route.h
>  but we can identify them now more easily.

and before anyone is going to start a bikeshed:

- Yes it's the nth time things are shuffled around because of this.

- I don't like it either.

- The proper ordering is needed for the moment.

- Another upcoming change would have tripped over this and broken
   LINTs which have a non-default (1) number of ROUTETABLES=2.

- People are thinking of a better solution for the
 	struct  radix_node_head *_rt_tables[RT_MAXFIBS][AF_MAX+1];
   in net/vnet.h.


/bz


-- 
Bjoern A. Zeeb                      The greatest risk is not taking one.