From owner-freebsd-bugs@FreeBSD.ORG Mon May 5 08:30:14 2003 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1739F37B401 for ; Mon, 5 May 2003 08:30:14 -0700 (PDT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1F28843F75 for ; Mon, 5 May 2003 08:30:13 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.9/8.12.9) with ESMTP id h45FUCUp066342 for ; Mon, 5 May 2003 08:30:12 -0700 (PDT) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.9/8.12.9/Submit) id h45FUCq7066341; Mon, 5 May 2003 08:30:12 -0700 (PDT) Resent-Date: Mon, 5 May 2003 08:30:12 -0700 (PDT) Resent-Message-Id: <200305051530.h45FUCq7066341@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Ryuichiro Imura Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7B3F237B401 for ; Mon, 5 May 2003 08:25:37 -0700 (PDT) Received: from mail.ryu16.org (YahooBB219005044040.bbtec.net [219.5.44.40]) by mx1.FreeBSD.org (Postfix) with ESMTP id AF37E43F75 for ; Mon, 5 May 2003 08:25:35 -0700 (PDT) (envelope-from imura@ryu16.org) Received: from redeye.xt.ryu16.org (localhost [IPv6:::1]) by mail.ryu16.org (8.12.6/8.12.5) with ESMTP id h45FOotW094521 for ; Tue, 6 May 2003 00:24:50 +0900 (JST) (envelope-from imura@redeye.xt.ryu16.org) Received: (from imura@localhost) by redeye.xt.ryu16.org (8.12.6/8.12.6/Submit) id h45FOoPk094520; Tue, 6 May 2003 00:24:50 +0900 (JST) Message-Id: <200305051524.h45FOoPk094520@redeye.xt.ryu16.org> Date: Tue, 6 May 2003 00:24:50 +0900 (JST) From: Ryuichiro Imura To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: kern/51798: sys/fs/ntfs/ntfs_subr.c ntfs_uastricmp() bug? X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Ryuichiro Imura List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 May 2003 15:30:14 -0000 >Number: 51798 >Category: kern >Synopsis: sys/fs/ntfs/ntfs_subr.c ntfs_uastricmp() bug? >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon May 05 08:30:12 PDT 2003 >Closed-Date: >Last-Modified: >Originator: Ryuichiro Imura >Release: FreeBSD 4.7-STABLE i386 >Organization: >Environment: System: FreeBSD redeye.xt.ryu16.org 4.7-STABLE FreeBSD 4.7-STABLE #5: Mon Jan 13 22:18:39 JST 2003 root@vrs:/usr/obj/usr/src/sys/U1 i386 >Description: ntfs_uastricmp() in src/sys/ntfs/ntfs_subr.c is curious. I think it should compare unicode and ascii string case insens, but it compares ascii string which converted from unicode string and unicode string which converted from ascii string. ntfs_uastrcmp() (difference from ntfs_uastricmp() is just case sens or insens) looks fine. Above paragraph may not hit you, so please look at the code. If I'm wrong, just close this PR. >How-To-Repeat: >Fix: Index: ntfs_subr.c =================================================================== RCS file: /home/ncvs/src/sys/fs/ntfs/ntfs_subr.c,v retrieving revision 1.29 diff -u -r1.29 ntfs_subr.c --- ntfs_subr.c 4 Mar 2003 00:04:42 -0000 1.29 +++ ntfs_subr.c 5 May 2003 15:09:46 -0000 @@ -674,7 +674,7 @@ */ for (i = 0; i < ustrlen && i < astrlen; i++) { res = ((int) NTFS_TOUPPER(NTFS_82U(NTFS_U28(ustr[i])))) - - ((int)NTFS_TOUPPER(NTFS_82U(astr[i]))); + ((int)NTFS_TOUPPER(astr[i])); if (res) return res; } >Release-Note: >Audit-Trail: >Unformatted: