From owner-freebsd-fs@FreeBSD.ORG Fri May 9 15:18:01 2003 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7AC3137B401 for ; Fri, 9 May 2003 15:18:01 -0700 (PDT) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8303543F3F for ; Fri, 9 May 2003 15:18:00 -0700 (PDT) (envelope-from phk@phk.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.9/8.12.9) with ESMTP id h49MHxxa015150; Sat, 10 May 2003 00:17:59 +0200 (CEST) (envelope-from phk@phk.freebsd.dk) To: Lukas Ertl From: "Poul-Henning Kamp" In-Reply-To: Your message of "Sat, 10 May 2003 00:07:26 +0200." <20030510000438.Y638@korben.in.tern> Date: Sat, 10 May 2003 00:17:59 +0200 Message-ID: <15149.1052518679@critter.freebsd.dk> cc: freebsd-fs@freebsd.org Subject: Re: newfs: useless/bogus check if new last block can be accessed? X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 May 2003 22:18:01 -0000 In message <20030510000438.Y638@korben.in.tern>, Lukas Ertl writes: >> syv# newfs -s 2049 md5 >> newfs: /dev/md5: maximum file system size is 2048 >> syv# > >But since this size check comes much earlier in the code, I guess the >wtfs() call is useless and should be removed, shouldn't it? If the check still works, I'd tend to keep it on the basis that it does no harm, but if you tell me that it would never result in an error, then we might as well remove it. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.