From owner-svn-src-all@FreeBSD.ORG Thu Dec 18 21:44:52 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 0599D30C for ; Thu, 18 Dec 2014 21:44:52 +0000 (UTC) Received: from mail-pa0-x22b.google.com (mail-pa0-x22b.google.com [IPv6:2607:f8b0:400e:c03::22b]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B99DD2B81 for ; Thu, 18 Dec 2014 21:44:51 +0000 (UTC) Received: by mail-pa0-f43.google.com with SMTP id kx10so2213118pab.30 for ; Thu, 18 Dec 2014 13:44:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netflix.com; s=google; h=from:content-type:mime-version:subject:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=f1J7Hxn2uJ4GShRjwhCZpH6jX2Z3Z7+ynzB3G5o7ZE0=; b=ql7dCDIniAswVOZfMjiDFx33jC3VE+AKW32hgdpPHd4wb+oeEVz1R6wHlr8JqvdFpy p4vQQEaOpd5x8BeLITnRsbHLqc+p4hW/omtupdTq8KiJjNy8WrLfb5fRL8EUtXcB0boq w6HixYJK/AXfxsRqT7tJ/sRJnNj0jl/KD4tXQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:content-type:mime-version:subject :in-reply-to:date:cc:content-transfer-encoding:message-id:references :to; bh=f1J7Hxn2uJ4GShRjwhCZpH6jX2Z3Z7+ynzB3G5o7ZE0=; b=Fex4LLpju6cpQe6YxvHoT+cfuKsyOCxz4+pisJeDW/8wTj89wd2pJEH0a0TKbSdOhe T5x4KmtifOXcMUXpMXMOUC1P/HidcFLqy9pYbWEVGIjGSUm59VeMVBG3bCfOpmDgVv9Y Jpgr1RmbLSyBaC8Q/t8+qKFUN3q4CZviCQJt7HwQ5S152iksJLc/Qi5V0Teegt8ikPvS nq7D7dil1JbOqDr6XKbvd8uaPyFtF7GoIHioISiQ0SzNKLfPynJOpO3qaas9iLS8Luev t8IGQznkAM+mOVp7m9S39xjxFFer1DsJ1UEpyQjjZqZYSuMseXqjnRjJZFblnZS8jQsu fOoQ== X-Gm-Message-State: ALoCoQmpW/ULf5P2z4TP2TW2pGtvUtU/s40/+r+sYuaX72LXFklae1yAxdFWwLFmPMZXTJlP+0JY X-Received: by 10.66.222.42 with SMTP id qj10mr7027782pac.47.1418939091232; Thu, 18 Dec 2014 13:44:51 -0800 (PST) Received: from [10.64.25.114] ([69.53.236.236]) by mx.google.com with ESMTPSA id f4sm7588909pdk.87.2014.12.18.13.44.49 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 18 Dec 2014 13:44:50 -0800 (PST) From: Warner Losh X-Google-Original-From: Warner Losh Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 8.1 \(1993\)) Subject: Re: svn commit: r275819 - in head/lib/msun: ld128 ld80 src In-Reply-To: <20141217211654.GA95193@troutmask.apl.washington.edu> Date: Thu, 18 Dec 2014 14:44:47 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: <18504F2A-72C1-4962-86E6-CCAE4898B478@gmail.com> References: <201412160921.sBG9LvFY064961@svn.freebsd.org> <20141216162055.GA64273@troutmask.apl.washington.edu> <20141217191235.GA89501@troutmask.apl.washington.edu> <87FF0FD4-EEF2-4264-9CBA-4B3A46E52FCB@gmail.com> <20141217211654.GA95193@troutmask.apl.washington.edu> To: Steve Kargl X-Mailer: Apple Mail (2.1993) Cc: Ed Schouten , src-committers@freebsd.org, svn-src-all@freebsd.org, Dimitry Andric , svn-src-head@freebsd.org, Garrett Cooper X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Dec 2014 21:44:52 -0000 > On Dec 17, 2014, at 2:16 PM, Steve Kargl = wrote: >=20 >=20 > Ed's diff is ~1000 lines and touches several files. Localizing > the change to math_private.h would have been a ~20 line > diff to a single file. Then just back his change out, put yours in and we all win. This seems = like ample =E2=80=9Cthis is better=E2=80=9D justification to me. While there = is a little more churn, external trackers will apply then unapply the churn, resulting in a net win. = Especially if you do the blackout as one commit and the better fix as another, which means = external trackers can just skip the two commits of churn with little effort on = their part. Warner