From owner-svn-src-all@FreeBSD.ORG Thu Dec 18 22:15:19 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 8BEDD94E; Thu, 18 Dec 2014 22:15:19 +0000 (UTC) Received: from mail-wi0-x230.google.com (mail-wi0-x230.google.com [IPv6:2a00:1450:400c:c05::230]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 15A862F73; Thu, 18 Dec 2014 22:15:19 +0000 (UTC) Received: by mail-wi0-f176.google.com with SMTP id ex7so107904wid.9; Thu, 18 Dec 2014 14:15:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type:content-transfer-encoding; bh=zvreUWlO4plXJa3aHJ/nQtCCq5N/Ytxdf/Yxo2PnkJ8=; b=usUd8hZ5pmMhB5sEKte7/eDBIOkAqYrYaIRG7LiLmyiHhGBkJDQKRZbaeFdSL1Hiev sIkyjO4mOyspC9KMASZvahiaSnwFEriVg930+EgCbrSY2sEjKcnZ3Tc8gTzfrau+cR9L 5wt98oLfPUvAQhD57JmAyY2U3/ijBo3Wnrt5CmfoIIxsXZsM94OtKgqIj3kQVMopAh4+ lENnh+R3AJ6B3MYrl2OkSiLGp3HHTkobw/j8arg/+karUFE6SUadIRRAANkeyZDA7dKq ONqQLaRbmWpgz3jUyAtWgzN0MJQk9OhMb+EP6Kcp0MO2DqPojzPRTS26GOi/hxWTMeFE 9JxA== MIME-Version: 1.0 X-Received: by 10.180.7.198 with SMTP id l6mr62131wia.26.1418940917209; Thu, 18 Dec 2014 14:15:17 -0800 (PST) Sender: adrian.chadd@gmail.com Received: by 10.216.106.195 with HTTP; Thu, 18 Dec 2014 14:15:17 -0800 (PST) In-Reply-To: <18504F2A-72C1-4962-86E6-CCAE4898B478@gmail.com> References: <201412160921.sBG9LvFY064961@svn.freebsd.org> <20141216162055.GA64273@troutmask.apl.washington.edu> <20141217191235.GA89501@troutmask.apl.washington.edu> <87FF0FD4-EEF2-4264-9CBA-4B3A46E52FCB@gmail.com> <20141217211654.GA95193@troutmask.apl.washington.edu> <18504F2A-72C1-4962-86E6-CCAE4898B478@gmail.com> Date: Thu, 18 Dec 2014 14:15:17 -0800 X-Google-Sender-Auth: yTwglBbDqG-xUQi03xCy28xoPqA Message-ID: Subject: Re: svn commit: r275819 - in head/lib/msun: ld128 ld80 src From: Adrian Chadd To: Warner Losh Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: Ed Schouten , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , Dimitry Andric , Steve Kargl , "svn-src-head@freebsd.org" , Garrett Cooper X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Dec 2014 22:15:19 -0000 On 18 December 2014 at 13:44, Warner Losh wrote: > >> On Dec 17, 2014, at 2:16 PM, Steve Kargl wrote: >> >> >> Ed's diff is ~1000 lines and touches several files. Localizing >> the change to math_private.h would have been a ~20 line >> diff to a single file. > > Then just back his change out, put yours in and we all win. This seems li= ke > ample =E2=80=9Cthis is better=E2=80=9D justification to me. While there i= s a little more churn, external > trackers will apply then unapply the churn, resulting in a net win. Espec= ially if you > do the blackout as one commit and the better fix as another, which means = external > trackers can just skip the two commits of churn with little effort on the= ir part. +1 And although the initial source stuff was a bit of a debate, I'm glad that it led to a much cleaner looking long term solution. -adrian