From owner-freebsd-net@FreeBSD.ORG  Thu Jan 17 03:08:07 2008
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 64C5E16A419
	for <freebsd-net@freebsd.org>; Thu, 17 Jan 2008 03:08:07 +0000 (UTC)
	(envelope-from thompsa@FreeBSD.org)
Received: from heff.fud.org.nz (203-109-251-39.static.bliink.ihug.co.nz
	[203.109.251.39])
	by mx1.freebsd.org (Postfix) with ESMTP id BD35813C447
	for <freebsd-net@freebsd.org>; Thu, 17 Jan 2008 03:08:06 +0000 (UTC)
	(envelope-from thompsa@FreeBSD.org)
Received: by heff.fud.org.nz (Postfix, from userid 1001)
	id C331377D4; Thu, 17 Jan 2008 16:08:04 +1300 (NZDT)
Date: Thu, 17 Jan 2008 16:08:04 +1300
From: Andrew Thompson <thompsa@FreeBSD.org>
To: Tom Judge <tom@tomjudge.com>
Message-ID: <20080117030804.GA30931@heff.fud.org.nz>
References: <478EBBFD.4090806@tomjudge.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <478EBBFD.4090806@tomjudge.com>
User-Agent: Mutt/1.5.16 (2007-06-09)
Cc: freebsd-net <freebsd-net@freebsd.org>
Subject: Re: if_bridge forwarding incorrectly forwarding ethernet link
	local addressed packets (e.g. lldp)
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 17 Jan 2008 03:08:07 -0000

On Thu, Jan 17, 2008 at 02:22:53AM +0000, Tom Judge wrote:
>
> Hi,
>
> As brought up in the thread "Programming interface MAC filter without 
> enabling PROMISC on an interface from user space." it would seem that 
> if_bridge does not conform to IEEE 802.1D-2004.  Which states:
>
> <quote>
> 7.12.6 Reserved addresses
> Frames containing any of the group MAC Addresses specified in Table 7-10 in 
> their destination address field shall not be relayed by the Bridge. They 
> are configured in the Permanent Database. Management shall not provide the 
> capability to modify or remove these entries from the Permanent or the 
> Filtering Databases. These group MAC Addresses are reserved for assignment 
> to standard protocols, according to the criteria for such assignments 
> (Clause 5.5 of ISO/IEC TR 11802-2).
> </quote>
>
>
> <table 7-10>
>                      Assignment                            Value
> Bridge Group Address                              01-80-C2-00-00-00
> IEEE Std 802.3x Full Duplex PAUSE operation       01-80-C2-00-00-01
> IEEE Std 802.3ad Slow_Protocols_Multicast address 01-80-C2-00-00-02
> IEEE P802.1X PAE address                          01-80-C2-00-00-03
> Reserved for future standardization               01-80-C2-00-00-04
> Reserved for future standardization               01-80-C2-00-00-05
> Reserved for future standardization               01-80-C2-00-00-06
> Reserved for future standardization               01-80-C2-00-00-07
> Reserved for future standardization               01-80-C2-00-00-08
> Reserved for future standardization               01-80-C2-00-00-09
> Reserved for future standardization               01-80-C2-00-00-0A
> Reserved for future standardization               01-80-C2-00-00-0B
> Reserved for future standardization               01-80-C2-00-00-0C
> Reserved for future standardization               01-80-C2-00-00-0D
> Reserved for future standardization               01-80-C2-00-00-0E
> Reserved for future standardization               01-80-C2-00-00-0F
> </table 7-10>
>
> Should I raise a PR about this?

Yes please, just paste the same content in. Thanks for investigating
this, I will sort out a patch.


Andrew