From owner-svn-src-head@FreeBSD.ORG  Sat Sep 18 11:45:10 2010
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 5A7CB106566B;
	Sat, 18 Sep 2010 11:45:10 +0000 (UTC)
	(envelope-from stefan@fafoe.narf.at)
Received: from fep23.mx.upcmail.net (fep23.mx.upcmail.net [62.179.121.43])
	by mx1.freebsd.org (Postfix) with ESMTP id BB3848FC1B;
	Sat, 18 Sep 2010 11:45:08 +0000 (UTC)
Received: from edge04.upcmail.net ([192.168.13.239]) by viefep11-int.chello.at
	(InterMail vM.8.01.02.02 201-2260-120-106-20100312) with ESMTP
	id <20100918112343.SVJM4509.viefep11-int.chello.at@edge04.upcmail.net>; 
	Sat, 18 Sep 2010 13:23:43 +0200
Received: from mole.fafoe.narf.at ([213.47.85.26])
	by edge04.upcmail.net with edge
	id 8BPh1f05M0a5KZh04BPi6A; Sat, 18 Sep 2010 13:23:43 +0200
X-SourceIP: 213.47.85.26
Received: by mole.fafoe.narf.at (Postfix, from userid 1001)
	id A02896D439; Sat, 18 Sep 2010 13:23:41 +0200 (CEST)
Date: Sat, 18 Sep 2010 13:23:41 +0200
From: Stefan Farfeleder <stefanf@FreeBSD.org>
To: Pawel Jakub Dawidek <pjd@FreeBSD.org>
Message-ID: <20100918112341.GA1733@mole.fafoe.narf.at>
References: <201009172251.o8HMpjZJ044307@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201009172251.o8HMpjZJ044307@svn.freebsd.org>
User-Agent: Mutt/1.5.20 (2009-06-14)
X-Cloudmark-Analysis: v=1.1 cv=ZDt3ILgE3VX9xkJc7+9REBIC4hFTL6V7NAq0V56QRNQ=
	c=1 sm=0 a=h7MPh2D0RE8A:10 a=kj9zAlcOel0A:10 a=6I5d2MoRAAAA:8
	a=15cyhmPGUgWBd1Axkl0A:9 a=1g8AJalCpwuiQ2vk4RMA:7
	a=DppC85V-0hkMsPaI1HWbjYsOHS8A:4 a=CjuIK1q_8ugA:10
	a=HpAAvcLHHh0Zw7uRqdWCyQ==:117
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r212804 - head/sys/boot/zfs
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 18 Sep 2010 11:45:10 -0000

Um, was the change from 32 to 31 deliberate?

On Fri, Sep 17, 2010 at 10:51:45PM +0000, Pawel Jakub Dawidek wrote:
> Author: pjd
> Date: Fri Sep 17 22:51:45 2010
> New Revision: 212804
> URL: http://svn.freebsd.org/changeset/base/212804
> 
> Log:
>   Remove magic value.
> 
> Modified:
>   head/sys/boot/zfs/zfs.c
> 
> Modified: head/sys/boot/zfs/zfs.c
> ==============================================================================
> --- head/sys/boot/zfs/zfs.c	Fri Sep 17 22:05:27 2010	(r212803)
> +++ head/sys/boot/zfs/zfs.c	Fri Sep 17 22:51:45 2010	(r212804)
> @@ -45,6 +45,8 @@ __FBSDID("$FreeBSD$");
>  
>  #include "zfsimpl.c"
>  
> +#define	MAXBDDEV	31
> +
>  static int	zfs_open(const char *path, struct open_file *f);
>  static int	zfs_write(struct open_file *f, void *buf, size_t size, size_t *resid);
>  static int	zfs_close(struct open_file *f);
> @@ -402,7 +404,7 @@ zfs_dev_init(void) 
>  	 * diskN, diskNpM or diskNsM.
>  	 */
>  	zfs_init();
> -	for (unit = 0; unit < 32 /* XXX */; unit++) {
> +	for (unit = 0; unit < MAXBDDEV; unit++) {
>  		sprintf(devname, "disk%d:", unit);
>  		fd = open(devname, O_RDONLY);
>  		if (fd == -1)
>