From owner-freebsd-ports-bugs@FreeBSD.ORG Sat Jun 15 12:20:00 2013 Return-Path: Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id D4A64E34 for ; Sat, 15 Jun 2013 12:20:00 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id A05A4160A for ; Sat, 15 Jun 2013 12:20:00 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id r5FCK0I7065715 for ; Sat, 15 Jun 2013 12:20:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id r5FCK0ug065713; Sat, 15 Jun 2013 12:20:00 GMT (envelope-from gnats) Resent-Date: Sat, 15 Jun 2013 12:20:00 GMT Resent-Message-Id: <201306151220.r5FCK0ug065713@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, John Marino Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id B71A4CCD for ; Sat, 15 Jun 2013 12:16:33 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from oldred.freebsd.org (oldred.freebsd.org [8.8.178.121]) by mx1.freebsd.org (Postfix) with ESMTP id DDC7E15F9 for ; Sat, 15 Jun 2013 12:16:33 +0000 (UTC) Received: from oldred.freebsd.org ([127.0.1.6]) by oldred.freebsd.org (8.14.5/8.14.7) with ESMTP id r5FCGX4G059719 for ; Sat, 15 Jun 2013 12:16:33 GMT (envelope-from nobody@oldred.freebsd.org) Received: (from nobody@localhost) by oldred.freebsd.org (8.14.5/8.14.5/Submit) id r5FCGX1j059718; Sat, 15 Jun 2013 12:16:33 GMT (envelope-from nobody) Message-Id: <201306151216.r5FCGX1j059718@oldred.freebsd.org> Date: Sat, 15 Jun 2013 12:16:33 GMT From: John Marino To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Subject: ports/179571: [PATCH] devel/gccmakedep: improve gcpp test (764 dports broke) X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 15 Jun 2013 12:20:00 -0000 >Number: 179571 >Category: ports >Synopsis: [PATCH] devel/gccmakedep: improve gcpp test (764 dports broke) >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sat Jun 15 12:20:00 UTC 2013 >Closed-Date: >Last-Modified: >Originator: John Marino >Release: >Organization: >Environment: >Description: During the last change to gccmakedep, a configuration item based on a test for gcpp based on $OSVERSION was added. Since it's trivial to actually test for the presence of gcpp, this should be used instead of $OSVERSION checks. Not only is it a better test, but it's also non-platform specific. 764 Dragonfly dports broke because of the new gcpp test. Please change the test per applied patch -- it should be transparent for FreeBSD. >How-To-Repeat: >Fix: Patch attached with submission follows: --- Makefile.orig 2013-06-15 12:01:35.215015000 +0000 +++ Makefile @@ -17,8 +17,7 @@ PLIST_FILES= bin/gccmakedep .include # Attempt to force use of GNU cpp, if it is installed as /usr/bin/gcpp. -.if (${OSVERSION} >= 900506 && ${OSVERSION} < 1000000) || \ - ${OSVERSION} >= 1000010 +.if exists(/usr/bin/gcpp) CONFIGURE_ENV+= ac_cv_path_RAWCPP="gcpp" .endif >Release-Note: >Audit-Trail: >Unformatted: