From owner-svn-src-all@FreeBSD.ORG  Thu Dec 18 23:59:09 2014
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id E521C806;
 Thu, 18 Dec 2014 23:59:09 +0000 (UTC)
Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu
 [128.95.76.21])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "troutmask", Issuer "troutmask" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id BE0C71F32;
 Thu, 18 Dec 2014 23:59:09 +0000 (UTC)
Received: from troutmask.apl.washington.edu (localhost [127.0.0.1])
 by troutmask.apl.washington.edu (8.14.9/8.14.9) with ESMTP id sBINx2e1001799
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Thu, 18 Dec 2014 15:59:02 -0800 (PST)
 (envelope-from sgk@troutmask.apl.washington.edu)
Received: (from sgk@localhost)
 by troutmask.apl.washington.edu (8.14.9/8.14.9/Submit) id sBINx2Vp001798;
 Thu, 18 Dec 2014 15:59:02 -0800 (PST) (envelope-from sgk)
Date: Thu, 18 Dec 2014 15:59:02 -0800
From: Steve Kargl <sgk@troutmask.apl.washington.edu>
To: Warner Losh <wlosh@netflix.com>
Subject: Re: svn commit: r275819 - in head/lib/msun: ld128 ld80 src
Message-ID: <20141218235902.GA1590@troutmask.apl.washington.edu>
References: <201412160921.sBG9LvFY064961@svn.freebsd.org>
 <20141216162055.GA64273@troutmask.apl.washington.edu>
 <CAJOYFBAAe_3psxdDC1Oq0+W=9T4qnSDK=tST3pP6q1iBpgME1w@mail.gmail.com>
 <20141217191235.GA89501@troutmask.apl.washington.edu>
 <87FF0FD4-EEF2-4264-9CBA-4B3A46E52FCB@gmail.com>
 <20141217211654.GA95193@troutmask.apl.washington.edu>
 <18504F2A-72C1-4962-86E6-CCAE4898B478@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <18504F2A-72C1-4962-86E6-CCAE4898B478@gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: Ed Schouten <ed@80386.nl>, src-committers@freebsd.org,
 svn-src-all@freebsd.org, Dimitry Andric <dim@FreeBSD.org>,
 svn-src-head@freebsd.org, Garrett Cooper <yaneurabeya@gmail.com>
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Dec 2014 23:59:10 -0000

On Thu, Dec 18, 2014 at 02:44:47PM -0700, Warner Losh wrote:
> 
> > On Dec 17, 2014, at 2:16 PM, Steve Kargl <sgk@troutmask.apl.washington.edu> wrote:
> > 
> > 
> > Ed's diff is ~1000 lines and touches several files.  Localizing
> > the change to math_private.h would have been a ~20 line
> > diff to a single file.
> 
> Then just back his change out, put yours in and we all win.

I had already written that I would not ask Ed to revert his change
due to the excessive code churn.  You may interpret this to mean
that I will not unfix what was not needed to be fix to begin with.
My only hope now is that Ed will fix the comment he inserted into
math_private.h to properly note that the functions formerly known
as cpack[fl] were written years before the C11 macros CMPLX[FL]
existed.

-- 
Steve