From owner-svn-src-all@FreeBSD.ORG Sat Jan 22 15:09:23 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 74C53106566B; Sat, 22 Jan 2011 15:09:23 +0000 (UTC) (envelope-from gljennjohn@googlemail.com) Received: from mail-fx0-f54.google.com (mail-fx0-f54.google.com [209.85.161.54]) by mx1.freebsd.org (Postfix) with ESMTP id A686F8FC15; Sat, 22 Jan 2011 15:09:22 +0000 (UTC) Received: by fxm16 with SMTP id 16so2897583fxm.13 for ; Sat, 22 Jan 2011 07:09:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:date:from:to:cc:subject:message-id:in-reply-to :references:reply-to:x-mailer:mime-version:content-type :content-transfer-encoding; bh=+YMpy+Pj4xSOHw7x127H8vorgdyQ2EFcubuK85lgZF8=; b=j96wiDM/mOi7JmuHkxcm4A4oWH0iJCXbKVnJkm/n0dIkl06qE+rdj7Ba9xW5RBn8JO 2zb8NI+2QyhFjNKZN20n1ALRivtheVp9OSUQJDzIypsojid0dRR8/4bPIVZvJYTe3tFf ExCddsbB4jeI/ASwqqvhIY5OpyrlqANT9bjnQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=date:from:to:cc:subject:message-id:in-reply-to:references:reply-to :x-mailer:mime-version:content-type:content-transfer-encoding; b=QepKrZveyr3so79i4BIO0Pt2QXBkGNEat7xItJuZ+GNwMtBfWYmImtq80j2RWLZUbv ywBVG4m/AVFpfACGDLkLowBWSgHqI079Mjuau366Lm+c58ofG2sXBghHsA62UkayzARQ 24bCorgGNbvEVqY8M2lBPKxUAsqKTZFwhu/eU= Received: by 10.223.93.140 with SMTP id v12mr2011667fam.96.1295708961456; Sat, 22 Jan 2011 07:09:21 -0800 (PST) Received: from ernst.jennejohn.org (p578E3BC5.dip.t-dialin.net [87.142.59.197]) by mx.google.com with ESMTPS id n7sm3991602fam.35.2011.01.22.07.09.20 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sat, 22 Jan 2011 07:09:21 -0800 (PST) Date: Sat, 22 Jan 2011 16:09:18 +0100 From: Gary Jennejohn To: Hans Petter Selasky Message-ID: <20110122160918.373f8670@ernst.jennejohn.org> In-Reply-To: <201101221352.p0MDqNt3093630@svn.freebsd.org> References: <201101221352.p0MDqNt3093630@svn.freebsd.org> X-Mailer: Claws Mail 3.7.8 (GTK+ 2.18.7; amd64-portbld-freebsd9.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r217718 - in head/sys: conf dev/usb X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: gljennjohn@googlemail.com List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Jan 2011 15:09:23 -0000 On Sat, 22 Jan 2011 13:52:23 +0000 (UTC) Hans Petter Selasky wrote: > Author: hselasky > Date: Sat Jan 22 13:52:23 2011 > New Revision: 217718 > URL: http://svn.freebsd.org/changeset/base/217718 > > Log: > Allow USB_HOST_ALIGN to be configured at compile time. This patch is > necessary for MIPS based RouterStation Pro board and maybe other MIPS > based boards as well. > > Submitted by: Milan Obuch > Approved by: thompsa (mentor) > > Modified: > head/sys/conf/options > head/sys/dev/usb/usb_freebsd.h > > Modified: head/sys/conf/options > ============================================================================== > --- head/sys/conf/options Sat Jan 22 13:18:28 2011 (r217717) > +++ head/sys/conf/options Sat Jan 22 13:52:23 2011 (r217718) > @@ -642,6 +642,7 @@ BUS_DEBUG opt_bus.h > > # options for USB support > USB_DEBUG opt_usb.h > +USB_HOST_ALIGN opt_usb.h > USB_REQ_DEBUG opt_usb.h > USB_VERBOSE opt_usb.h > USB_EHCI_BIG_ENDIAN_DESC opt_usb.h > > Modified: head/sys/dev/usb/usb_freebsd.h > ============================================================================== > --- head/sys/dev/usb/usb_freebsd.h Sat Jan 22 13:18:28 2011 (r217717) > +++ head/sys/dev/usb/usb_freebsd.h Sat Jan 22 13:52:23 2011 (r217718) > @@ -46,7 +46,12 @@ > #define USB_TD_GET_PROC(td) (td)->td_proc > #define USB_PROC_GET_GID(td) (td)->p_pgid > > +#if defined(USB_HOST_ALIGN) && (USB_HOST_ALIGN != 0) > +/* USB_HOST_ALIGN is already defined and valid */ > Not necessarily valid. What if the user sets it to -24? The compiler will happily accept that with the above #if-statement. IMO you should test for USB_HOST_ALIGN > 0, which should always work. Defensive programming is always a good idea. > +#else > +#undef USB_HOST_ALIGN > #define USB_HOST_ALIGN 8 /* bytes, must be power of two */ > +#endif > #define USB_FS_ISOC_UFRAME_MAX 4 /* exclusive unit */ > #define USB_BUS_MAX 256 /* units */ > #define USB_MAX_DEVICES 128 /* units */ > _______________________________________________ > svn-src-all@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/svn-src-all > To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" -- Gary Jennejohn