From owner-svn-src-all@FreeBSD.ORG  Sat Jun 19 16:29:24 2010
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 477F9106564A;
	Sat, 19 Jun 2010 16:29:24 +0000 (UTC)
	(envelope-from gavin@FreeBSD.org)
Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c])
	by mx1.freebsd.org (Postfix) with ESMTP id 360F88FC15;
	Sat, 19 Jun 2010 16:29:24 +0000 (UTC)
Received: from svn.freebsd.org (localhost [127.0.0.1])
	by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id o5JGTNCb033502;
	Sat, 19 Jun 2010 16:29:23 GMT (envelope-from gavin@svn.freebsd.org)
Received: (from gavin@localhost)
	by svn.freebsd.org (8.14.3/8.14.3/Submit) id o5JGTN6x033499;
	Sat, 19 Jun 2010 16:29:23 GMT (envelope-from gavin@svn.freebsd.org)
Message-Id: <201006191629.o5JGTN6x033499@svn.freebsd.org>
From: Gavin Atkinson <gavin@FreeBSD.org>
Date: Sat, 19 Jun 2010 16:29:23 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
	svn-src-head@freebsd.org
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Cc: 
Subject: svn commit: r209343 - head/usr.sbin/cpucontrol
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 19 Jun 2010 16:29:24 -0000

Author: gavin
Date: Sat Jun 19 16:29:23 2010
New Revision: 209343
URL: http://svn.freebsd.org/changeset/base/209343

Log:
  Remove dead assignments, we overwrite the variable almost immediately.
  
  Found by:	clang static analyzer

Modified:
  head/usr.sbin/cpucontrol/amd.c
  head/usr.sbin/cpucontrol/intel.c

Modified: head/usr.sbin/cpucontrol/amd.c
==============================================================================
--- head/usr.sbin/cpucontrol/amd.c	Sat Jun 19 16:24:55 2010	(r209342)
+++ head/usr.sbin/cpucontrol/amd.c	Sat Jun 19 16:29:23 2010	(r209343)
@@ -92,9 +92,7 @@ amd_update(const char *dev, const char *
 	assert(dev);
 
 	fd  = -1;
-	devfd = -1;
 	fw_image = MAP_FAILED;
-	error = 0;
 	devfd = open(dev, O_RDWR);
 	if (devfd < 0) {
 		WARN(0, "could not open %s for writing", dev);

Modified: head/usr.sbin/cpucontrol/intel.c
==============================================================================
--- head/usr.sbin/cpucontrol/intel.c	Sat Jun 19 16:24:55 2010	(r209342)
+++ head/usr.sbin/cpucontrol/intel.c	Sat Jun 19 16:29:23 2010	(r209343)
@@ -104,7 +104,6 @@ intel_update(const char *dev, const char
 	assert(dev);
 
 	fd = -1;
-	devfd = -1;
 	fw_image = MAP_FAILED;
 	ext_table = NULL;
 	ext_header = NULL;