From owner-freebsd-ports-bugs@FreeBSD.ORG Thu Sep 7 08:50:14 2006 Return-Path: X-Original-To: freebsd-ports-bugs@hub.freebsd.org Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1FCCF16A4DD for ; Thu, 7 Sep 2006 08:50:14 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5DF9143D49 for ; Thu, 7 Sep 2006 08:50:13 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k878oD4B001353 for ; Thu, 7 Sep 2006 08:50:13 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k878oDoX001351; Thu, 7 Sep 2006 08:50:13 GMT (envelope-from gnats) Resent-Date: Thu, 7 Sep 2006 08:50:13 GMT Resent-Message-Id: <200609070850.k878oDoX001351@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Marcus von Appen Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id ECD8716A4DF for ; Thu, 7 Sep 2006 08:45:21 +0000 (UTC) (envelope-from mail@sysfault.org) Received: from smtprelay03.ispgateway.de (smtprelay03.ispgateway.de [80.67.18.15]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6272A43D5E for ; Thu, 7 Sep 2006 08:45:19 +0000 (GMT) (envelope-from mail@sysfault.org) Received: (qmail 4564 invoked from network); 7 Sep 2006 08:45:17 -0000 Received: from unknown (HELO medusa.sysfault.org) (936934@[81.14.177.118]) (envelope-sender ) by smtprelay03.ispgateway.de (qmail-ldap-1.03) with AES256-SHA encrypted SMTP for ; 7 Sep 2006 08:45:17 -0000 Received: from localhost ([127.0.0.1] helo=medusa.sysfault.org) by medusa.sysfault.org with esmtp (Exim 4.63 (FreeBSD)) (envelope-from ) id 1GLFYT-000Oo5-Nb for FreeBSD-gnats-submit@freebsd.org; Thu, 07 Sep 2006 10:48:13 +0200 Received: (from marcus@localhost) by medusa.sysfault.org (8.13.1/8.13.1/Submit) id k878mC1O095360; Thu, 7 Sep 2006 10:48:13 +0200 (CEST) (envelope-from marcus) Message-Id: <200609070848.k878mC1O095360@medusa.sysfault.org> Date: Thu, 7 Sep 2006 10:48:13 +0200 (CEST) From: Marcus von Appen To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/102971: [Maintiner-update]: sysutils/flexbackup PREFIX fix and OPTIONization X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Marcus von Appen List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Sep 2006 08:50:14 -0000 >Number: 102971 >Category: ports >Synopsis: [Maintiner-update]: sysutils/flexbackup PREFIX fix and OPTIONization >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: maintainer-update >Submitter-Id: current-users >Arrival-Date: Thu Sep 07 08:50:12 GMT 2006 >Closed-Date: >Last-Modified: >Originator: Marcus von Appen >Release: FreeBSD 6.1-STABLE i386 >Organization: >Environment: System: FreeBSD medusa.sysfault.org 6.1-STABLE FreeBSD 6.1-STABLE #12: Tue Aug 29 19:10:11 CEST 2006 root@medusa.sysfault.org:/usr/obj/usr/src/sys/MEDUSA i386 >Description: The following patch fixes the ugly PREFIX misbehaviour of flexbackup. By default it expects its configuration file, flexbackup.conf, in /etc/ as longas WITH_PREFIX_CONF is not explicitly set. I changed it to use PREFIX as default now, so flexbackup expects flexbackup.conf being in PREFIX/etc Before: /etc/flexbackup.conf for PREFIX=whatever, WITH_PREFIX_CONF unset Now: PREFIX/etc/flexbackup.conf for PREFIX=whatever The changed behaviour should be noted in UPDATING, I guess. The port make use of OPTIONS and got a revision bump for the PREFIX change. I'll take over maintainership for this. >How-To-Repeat: >Fix: diff -Nur flexbackup/Makefile flexbackup.new/Makefile --- flexbackup/Makefile Tue Sep 5 06:57:08 2006 +++ flexbackup.new/Makefile Thu Sep 7 10:33:32 2006 @@ -7,23 +7,28 @@ PORTNAME= flexbackup PORTVERSION= 1.2.1 +PORTREVISION= 1 CATEGORIES= sysutils MASTER_SITES= http://www.edwinh.org/flexbackup/tarball/ \ http://www.reynoldsnet.org/flexbackup/tarball/ -MAINTAINER= ports@FreeBSD.org +MAINTAINER= mva@sysfault.org COMMENT= Perl-based flexible backup system that can use dump/afio/cpio/tar/star PKGMESSAGE= ${WRKDIR}/pkg-message - MAKE_ARGS= PERLPATH=${PERL} - USE_PERL5= yes -.if defined(WITH_PREFIX_CONF) MAKE_ARGS+= CONFFILE=${PREFIX}/etc/flexbackup.conf CONFDIR= ${PREFIX} -.endif + +.include + +OPTIONS= AFIO "Enable afio support" Off \ + BUFFER "Enable buffer support" Off \ + GTAR "Enable gtar support" Off \ + STAR "Enable star support" Off \ + ZIP "Eanble zip support" Off .if defined(WITH_AFIO) RUN_DEPENDS+= afio:${PORTSDIR}/sysutils/afio @@ -46,22 +51,12 @@ .endif pre-fetch: - @${ECHO} "----------------------------------------------------------" - @${ECHO} "This port can utilize afio, star, zip, and buffer." - @${ECHO} "You may use the following build options to make:" - @${ECHO} - @${ECHO} " WITH_AFIO=yes enable the use of afio" - @${ECHO} " WITH_STAR=yes enable the use of star" - @${ECHO} " WITH_ZIP=yes enable the use of zip" - @${ECHO} " WITH_BUFFER=yes enable the use of buffer" - @${ECHO} - @${ECHO} "----------------------------------------------------------" - @${ECHO} + @${ECHO} "------------------------------------------------------------------------" @${ECHO} "If you are using and older version of FreeBSD that does not have GNU Tar" @${ECHO} "imported as the system 'tar,' configure this port using WITH_GTAR=yes" @${ECHO} "to enable the port dependency and use the 'path' variable in the" @${ECHO} "flexbackup.conf file to point to 'gtar'" - @${ECHO} + @${ECHO} "------------------------------------------------------------------------" MAN1= flexbackup.1 MAN5= flexbackup.conf.5 @@ -84,4 +79,4 @@ .endif @${CAT} ${PKGMESSAGE} -.include +.include >Release-Note: >Audit-Trail: >Unformatted: