From owner-freebsd-ports-bugs@FreeBSD.ORG Fri Dec 13 00:40:01 2013 Return-Path: Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 015EED32 for ; Fri, 13 Dec 2013 00:40:01 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id CD2C61871 for ; Fri, 13 Dec 2013 00:40:00 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id rBD0e0iw005424 for ; Fri, 13 Dec 2013 00:40:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id rBD0e0ue005423; Fri, 13 Dec 2013 00:40:00 GMT (envelope-from gnats) Resent-Date: Fri, 13 Dec 2013 00:40:00 GMT Resent-Message-Id: <201312130040.rBD0e0ue005423@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Garrett Wollman Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 6A05DC09 for ; Fri, 13 Dec 2013 00:34:29 +0000 (UTC) Received: from khavrinen.csail.mit.edu (khavrinen.csail.mit.edu [IPv6:2001:470:8b2d:1e1c:21b:21ff:feb8:d7b0]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 3C4E01840 for ; Fri, 13 Dec 2013 00:34:29 +0000 (UTC) Received: from xyz.csail.mit.edu (xyz.csail.mit.edu [128.31.0.28]) by khavrinen.csail.mit.edu (8.14.5/8.14.5) with ESMTP id rBD0YQHP010492 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO CN= issuer=) for ; Thu, 12 Dec 2013 19:34:26 -0500 (EST) (envelope-from wollman@xyz.csail.mit.edu) Received: (from root@localhost) by xyz.csail.mit.edu (8.14.7/8.14.5/Submit) id rBD0YQjm007557; Thu, 12 Dec 2013 19:34:26 -0500 (EST) (envelope-from wollman) Message-Id: <201312130034.rBD0YQjm007557@xyz.csail.mit.edu> Date: Thu, 12 Dec 2013 19:34:26 -0500 (EST) From: Garrett Wollman To: FreeBSD-gnats-submit@freebsd.org X-Send-Pr-Version: 3.114 Subject: ports/184736: net-mgmt/nagios-plugins has hidden dependency on ssh X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list Reply-To: Garrett Wollman List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Dec 2013 00:40:01 -0000 >Number: 184736 >Category: ports >Synopsis: net-mgmt/nagios-plugins has hidden dependency on ssh >Confidential: no >Severity: serious >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Fri Dec 13 00:40:00 UTC 2013 >Closed-Date: >Last-Modified: >Originator: Garrett Wollman >Release: FreeBSD 9.2-RELEASE-p2 amd64 >Organization: MIT Computer Science & Artificial Intelligence Laboratory >Environment: System: FreeBSD xyz.csail.mit.edu 9.2-RELEASE-p2 FreeBSD 9.2-RELEASE-p2 #1 r259144:259145M: Wed Dec 11 14:50:53 EST 2013 wollman@xyz.csail.mit.edu:/usr/obj/usr/src/sys/CSAIL amd64 World is build with WITHOUT_OPENSSH=yes in /etc/src.conf. >Description: The check_by_ssh plugin is unconditionally included in the packing list even when there is no ssh executable, but the configure script disables the installation of check_by_ssh if it can't find an ssh executable. This causes packaging to fail on systems where there is no /usr/bin/ssh. >How-To-Repeat: 1) build a poudriere jail with no /usr/bin/ssh 2) poudriere testport -o net-mgmt/nagios-plugins 3) watch it fail >Fix: As a workaround, I just added an unconditional dependency on security/openssh-portable (warning, cut and paste): Index: Makefile =================================================================== --- Makefile (revision 336291) +++ Makefile (working copy) @@ -147,6 +147,13 @@ PLIST_SUB+= SUB_DBI="@comment " .endif +# If we don't have /usr/bin/ssh then we must be on a system that uses +# packages for ssh, so depend on one. This should be an OPTION. +.if !exists(/usr/bin/ssh) +BUILD_DEPENDS+= ssh:${PORTSDIR}/security/openssh-portable +RUN_DEPENDS+= ssh:${PORTSDIR}/security/openssh-portable +.endif + post-patch: .for file in check_by_ssh.c check_disk.c check_http.c check_mrtgtraf.c \ check_nagios.c check_ntp.c check_ntp_peer.c check_ntp_time.c \ >Release-Note: >Audit-Trail: >Unformatted: