From owner-p4-projects Wed Jul 31 22:19:13 2002 Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 9386137B401; Wed, 31 Jul 2002 22:19:09 -0700 (PDT) Delivered-To: perforce@freebsd.org Received: from green.bikeshed.org (freefall.FreeBSD.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id 0424B37B400; Wed, 31 Jul 2002 22:19:07 -0700 (PDT) Received: from localhost (green@localhost) by green.bikeshed.org (8.11.6/8.11.6) with ESMTP id g715J5u26137; Thu, 1 Aug 2002 01:19:06 -0400 (EDT) (envelope-from green@green.bikeshed.org) Message-Id: <200208010519.g715J5u26137@green.bikeshed.org> X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 To: Robert Watson Cc: Brian Feldman , Perforce Change Reviews Subject: Re: PERFORCE change 15347 for review In-Reply-To: Your message of "Wed, 31 Jul 2002 22:41:27 EDT." From: "Brian F. Feldman" Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Thu, 01 Aug 2002 01:19:05 -0400 Sender: owner-p4-projects@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Robert Watson wrote: > > On Wed, 31 Jul 2002, Brian Feldman wrote: > > > http://people.freebsd.org/~peter/p4db/chv.cgi?CH=15347 > > > > Change 15347 by green@green_laptop_2 on 2002/07/31 14:31:24 > > > > mac_cred_canexec() no longer exists; use mac_check_vnode_exec(). > > Hmm. I see the problem you're trying to address by making these locking > changes (proc lock ordering relationship to vnode locks), but I'm not sure > the result of the changes is correct either. Releasing the proc lock here > may have undesirable consequences, since we're in the middle of a process > credential change... There's really nothing bad that can happen that I can tell. -- Brian Fundakowski Feldman \'[ FreeBSD ]''''''''''\ <> green@FreeBSD.org <> bfeldman@tislabs.com \ The Power to Serve! \ Opinions expressed are my own. \,,,,,,,,,,,,,,,,,,,,,,\ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe p4-projects" in the body of the message