From owner-freebsd-ports-bugs@FreeBSD.ORG Sat Sep 20 14:00:30 2014 Return-Path: Delivered-To: freebsd-ports-bugs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 17523F19 for ; Sat, 20 Sep 2014 14:00:30 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D7F82DAA for ; Sat, 20 Sep 2014 14:00:29 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id s8KE0TfQ008565 for ; Sat, 20 Sep 2014 14:00:29 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 193793] New: ports-mgmt/portlint: split 192633 - improve COMMENTS validation Date: Sat, 20 Sep 2014 14:00:29 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports Tree X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: marino@FreeBSD.org X-Bugzilla-Status: Needs Triage X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: marcus@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter flagtypes.name Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Sep 2014 14:00:30 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193793 Bug ID: 193793 Summary: ports-mgmt/portlint: split 192633 - improve COMMENTS validation Product: Ports Tree Version: Latest Hardware: Any OS: Any Status: Needs Triage Severity: Affects Only Me Priority: --- Component: Individual Port(s) Assignee: marcus@FreeBSD.org Reporter: marino@FreeBSD.org Assignee: marcus@FreeBSD.org Flags: maintainer-feedback?(marcus@FreeBSD.org) I frequently run into ports with "files" in the COMMENT definition. There's nothing wrong with that. However, portlint trips on it, e.g. WARN: Makefile: possible direct use of "files" "COMMENT= List, test, and extract compressed files in a ZIP archive" found. if so, use ${FILESDIR} instead. Please make the "files" check smarter to not trip if it's part of a COMMENT. (see archivers/unzip for example) Speaking of COMMENT, it's not supposed to start with "A ", "An ", or "The ", but portlint doesn't check for this. It seems like an easy rule to implement. It's also not supposed to start with the name of the port, but I have no idea if this rule is implemented or not. e.g. math/fractals COMMENT= Fractals is an awesome snowflake generator program Portlint could flag that. (does it already?) --- Comment #1 from Bugzilla Automation --- Auto-assigned to maintainer marcus@FreeBSD.org -- You are receiving this mail because: You are the assignee for the bug.