From owner-svn-src-all@FreeBSD.ORG  Thu Sep 16 01:43:55 2010
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id AB6201065679;
	Thu, 16 Sep 2010 01:43:55 +0000 (UTC)
	(envelope-from davidxu@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 7D83B8FC0C;
	Thu, 16 Sep 2010 01:43:55 +0000 (UTC)
Received: from [127.0.0.1] (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o8G1hrU1004987;
	Thu, 16 Sep 2010 01:43:54 GMT (envelope-from davidxu@freebsd.org)
Message-ID: <4C91E6DA.8050907@freebsd.org>
Date: Thu, 16 Sep 2010 09:43:54 +0000
From: David Xu <davidxu@freebsd.org>
User-Agent: Thunderbird 2.0.0.24 (X11/20100630)
MIME-Version: 1.0
To: "M. Warner Losh" <imp@bsdimp.com>
References: <201009150256.o8F2uXwX004579@svn.freebsd.org>	<20100914231728.33ca7466@kan.dnsalias.net>
	<20100915.081234.83306312380114674.imp@bsdimp.com>
In-Reply-To: <20100915.081234.83306312380114674.imp@bsdimp.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org, kabaev@gmail.com
Subject: Re: svn commit: r212630 - in head/lib/libthr: . thread
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 16 Sep 2010 01:43:55 -0000

M. Warner Losh wrote:
> In message: <20100914231728.33ca7466@kan.dnsalias.net>
>             Alexander Kabaev <kabaev@gmail.com> writes:
> : On Wed, 15 Sep 2010 02:56:33 +0000 (UTC)
> : David Xu <davidxu@FreeBSD.org> wrote:
> : 
> : > Author: davidxu
> : > Date: Wed Sep 15 02:56:32 2010
> : > New Revision: 212630
> : > URL: http://svn.freebsd.org/changeset/base/212630
> : > 
> : > Log:
> : >   add code to support stack unwinding when thread exits. note that
> : > only defer-mode cancellation works, asynchrnous mode does not work
> : > because it lacks of libuwind's support. stack unwinding is not
> : > enabled unless LIBTHR_UNWIND_STACK is defined in Makefile.
> : > 
> : > Modified:
> : >   head/lib/libthr/Makefile
> : >   head/lib/libthr/thread/thr_clean.c
> : >   head/lib/libthr/thread/thr_create.c
> : >   head/lib/libthr/thread/thr_exit.c
> : >   head/lib/libthr/thread/thr_init.c
> : >   head/lib/libthr/thread/thr_private.h
> : > 
> : > Modified: head/lib/libthr/Makefile
> : > ==============================================================================
> : > --- head/lib/libthr/Makefile	Wed Sep 15 01:21:30 2010
> : > (r212629) +++ head/lib/libthr/Makefile	Wed Sep 15 02:56:32
> : > 2010	(r212630) @@ -25,6 +25,14 @@
> : > CFLAGS+=-I${.CURDIR}/../../libexec/rtld-
> : > CFLAGS+=-I${.CURDIR}/../../libexec/rtld-elf/${MACHINE_CPUARCH}
> : > CFLAGS+=-I${.CURDIR}/../libthread_db CFLAGS+=-Winline
> : > +
> : > +LIBTHR_UNWIND_STACK=yes
> : > +
> : > +.ifdef LIBTHR_UNWIND_STACK
> : > +CFLAGS+=-I${.CURDIR}/../../contrib/gcc -fexceptions 
> : > +CFLAGS+=-D_PTHREAD_FORCED_UNWIND
> : > +.endif
> : > +
> : >
> : 
> : Reaching into bowels of GCC like that is never good.
> 
> Would this pulling in GPL'd code?
> 
> Warner
> 
It's being resolved.