From owner-freebsd-ports-bugs@FreeBSD.ORG Sat Apr 28 07:10:08 2012 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 334311065670 for ; Sat, 28 Apr 2012 07:10:08 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 0C78A8FC14 for ; Sat, 28 Apr 2012 07:10:08 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q3S7A7hW059324 for ; Sat, 28 Apr 2012 07:10:07 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q3S7A7Hi059323; Sat, 28 Apr 2012 07:10:07 GMT (envelope-from gnats) Resent-Date: Sat, 28 Apr 2012 07:10:07 GMT Resent-Message-Id: <201204280710.q3S7A7Hi059323@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Daniel Becker Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 24112106566C for ; Sat, 28 Apr 2012 07:05:34 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id 0FB3D8FC14 for ; Sat, 28 Apr 2012 07:05:34 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q3S75Xpg046513 for ; Sat, 28 Apr 2012 07:05:33 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id q3S75X54046512; Sat, 28 Apr 2012 07:05:33 GMT (envelope-from nobody) Message-Id: <201204280705.q3S75X54046512@red.freebsd.org> Date: Sat, 28 Apr 2012 07:05:33 GMT From: Daniel Becker To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/167385: [patch] netatalk 2.2.2 insists on using sendfile X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Apr 2012 07:10:08 -0000 >Number: 167385 >Category: ports >Synopsis: [patch] netatalk 2.2.2 insists on using sendfile >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Sat Apr 28 07:10:07 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Daniel Becker >Release: 9.0-RELEASE >Organization: >Environment: FreeBSD razzems.Stanford.EDU 9.0-RELEASE FreeBSD 9.0-RELEASE #0: Tue Jan 3 07:46:30 UTC 2012 root@farrell.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC amd64 >Description: After updating to version 2.2.2, Netatalk uses sendfile to transmit data to the client. As documented in kern/141305, this causes severe performance issues for Netatalk shares hosted on ZFS volumes, manifesting itself in extremely low network transfer speed, while causing excessive disk I/O. Please consider exposing the --disable-sendfile configure switch introduced in Netatalk 2.2.2 through the port's config options. >How-To-Repeat: - create Netatalk share on ZFS - read any files from the share - watch transfer rate and server-side disk I/O >Fix: Create a config option for disabling the use of sendfile. Patch attached. Patch attached with submission follows: --- Makefile 2012-04-28 00:04:10.224230833 -0700 +++ Makefile.new 2012-04-27 23:50:53.283177302 -0700 @@ -39,7 +39,8 @@ TIMELORD "Enable Timelord network time service" off \ KRB5 "Enable Kerberos V UAM" off \ ZEROCONF "Enable Zeroconf (Bonjour) support" on \ - LDAP "Enable LDAP support" off + LDAP "Enable LDAP support" off \ + SENDFILE "Enable sendfile support" off FILES= AppleVolumes.default AppleVolumes.system afpd.conf netatalk.conf LINKS= unbin unhex unsingle hqx2bin single2bin macbinary \ @@ -119,6 +120,12 @@ CONFIGURE_ARGS+= --without-ldap .endif +.if defined (WITH_SENDFILE) +CONFIGURE_ARGS+= --enable-sendfile +.else +CONFIGURE_ARGS+= --disable-sendfile +.endif + .if ${OSVERSION} < 800031 PLIST_SUB+= ATFUNCS="@comment " .else >Release-Note: >Audit-Trail: >Unformatted: