From owner-svn-src-all@FreeBSD.ORG Fri Apr 4 11:59:16 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 88E0BE40; Fri, 4 Apr 2014 11:59:16 +0000 (UTC) Received: from theravensnest.org (theraven.freebsd.your.org [216.14.102.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "theravensnest.org", Issuer "theravensnest.org" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 50E2D2EE; Fri, 4 Apr 2014 11:59:15 +0000 (UTC) Received: from [192.168.0.100] (cpc14-cmbg15-2-0-cust307.5-4.cable.virginm.net [82.26.1.52]) (authenticated bits=0) by theravensnest.org (8.14.7/8.14.7) with ESMTP id s34BxBeH072575 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Fri, 4 Apr 2014 11:59:13 GMT (envelope-from theraven@FreeBSD.org) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 7.2 \(1874\)) Subject: Re: svn commit: r264042 - in head: include lib/libc/gen lib/libc/include lib/libc/stdlib From: David Chisnall In-Reply-To: <20140404115256.GA85137@ivaldir.etoilebsd.net> Date: Fri, 4 Apr 2014 12:59:07 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: References: <201404021607.s32G7mhw051355@svn.freebsd.org> <20140404115256.GA85137@ivaldir.etoilebsd.net> To: Baptiste Daroussin X-Mailer: Apple Mail (2.1874) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Apr 2014 11:59:16 -0000 On 4 Apr 2014, at 12:52, Baptiste Daroussin wrote: > On Wed, Apr 02, 2014 at 04:07:48PM +0000, David Chisnall wrote: >> Author: theraven >> Date: Wed Apr 2 16:07:48 2014 >> New Revision: 264042 >> URL: http://svnweb.freebsd.org/changeset/base/264042 >>=20 >> Log: >> Add support for some block functions that come from OS X. These are >> intended to build with any C compiler. >>=20 >> Reviewed by: pfg >> MFC after: 3 weeks >=20 > This breaks a couple of ports starting with cups, those ports do = expect > libdispatch to be available if _BLOCK_ exists. Do you plan to import > libdispatch soon? __BLOCKS__ is a compiler predefine, which this doesn't change - it just = exposes some other functions *if* __BLOCKS__ is defined. I'm not sure = what _BLOCK_ is - is it something that their configure script is = defining? We do currently have some inconsistency in the base system, because gcc = defaults to -fblocks, whereas clang defaults to -fno-blocks on FreeBSD. = This means that __BLOCKS__ is defined when building with gcc from base, = but with clang from base or gcc from ports, but that's independent of = this change. I believe that libdispatch most likely won't be imported until there is = an in-tree consumer, but it's in ports and there's nothing stopping = ports depending on it if they want to use it... David