From owner-freebsd-doc@FreeBSD.ORG Wed Dec 31 11:12:11 2003 Return-Path: Delivered-To: freebsd-doc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2279216A4CE for ; Wed, 31 Dec 2003 11:12:11 -0800 (PST) Received: from mail4.speakeasy.net (mail4.speakeasy.net [216.254.0.204]) by mx1.FreeBSD.org (Postfix) with ESMTP id F251643D3F for ; Wed, 31 Dec 2003 11:12:09 -0800 (PST) (envelope-from jhb@FreeBSD.org) Received: (qmail 18053 invoked from network); 31 Dec 2003 19:12:09 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) encrypted SMTP for ; 31 Dec 2003 19:12:09 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.10/8.12.10) with ESMTP id hBVJC6M0093187; Wed, 31 Dec 2003 14:12:06 -0500 (EST) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.4 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <20031231194305.E69663@leelou.in.tern> Date: Wed, 31 Dec 2003 14:12:13 -0500 (EST) From: John Baldwin To: Lukas Ertl X-Spam-Checker-Version: SpamAssassin 2.55 (1.174.2.19-2003-05-19-exp) cc: freebsd-doc@FreeBSD.org Subject: Re: docs/60107: [PATCH] update sample code in PCI driver chapter of arch handbook X-BeenThere: freebsd-doc@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Documentation project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Dec 2003 19:12:11 -0000 On 31-Dec-2003 Lukas Ertl wrote: > On Wed, 31 Dec 2003, John Baldwin wrote: > >> Synopsis: [PATCH] update sample code in PCI driver chapter of arch handbook >> >> State-Changed-From-To: open->closed >> State-Changed-By: jhb >> State-Changed-When: Wed Dec 31 10:16:40 PST 2003 >> State-Changed-Why: >> Comitted, thanks! > > Hi John, > > thanks for committing this. FWIW, I think you introduced an error in rev. > 1.17: > > -mypci_close(dev_t dev, int fflag, int devtype, struct thread *td) > +mypci_close(dev_t dev, int fflag, int devtype, struct d_thread_t *td) > > I think there's one "struct" too much. :-) Argh, thanks! -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/