From owner-cvs-all@FreeBSD.ORG  Thu Feb 12 02:30:11 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 6DC0016A4CE; Thu, 12 Feb 2004 02:30:11 -0800 (PST)
Received: from srv01.sparkit.no (srv01.sparkit.no [193.69.116.226])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id DB63743D1D; Thu, 12 Feb 2004 02:30:10 -0800 (PST)
	(envelope-from eivind@FreeBSD.org)
Received: from ws ([193.69.114.88])
	by srv01.sparkit.no (8.12.10/8.12.10) with ESMTP id i1CAU5iA066767;
	Thu, 12 Feb 2004 11:30:05 +0100 (CET)
	(envelope-from eivind@FreeBSD.org)
Received: from ws (localhost [127.0.0.1])
	by ws (8.12.9/8.12.10) with ESMTP id i1CATkRe010653;
	Thu, 12 Feb 2004 10:29:46 GMT
	(envelope-from eivind@ws)
Received: (from eivind@localhost)
	by ws (8.12.9/8.12.10/Submit) id i1CATjDa010593;
	Thu, 12 Feb 2004 10:29:45 GMT
	(envelope-from eivind)
Date: Thu, 12 Feb 2004 10:28:45 +0000
From: Eivind Eklund <eivind@FreeBSD.org>
To: Trevor Johnson <trevor@jpj.net>
Message-ID: <20040212102842.GC3148@FreeBSD.org>
References: <200402110716.i1B7GH9D017803@repoman.freebsd.org>
	<xzpisidbtvn.fsf@dwp.des.no> <1076508074.88428.14.camel@pav.hide.vol.cz>
	<20040211122704.X93022@blues.jpj.net> <xzpk72tiah1.fsf@dwp.des.no>
	<20040211165940.Q98525@blues.jpj.net> <xzp4qtweqlf.fsf@dwp.des.no>
	<20040212031228.E31447@blues.jpj.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20040212031228.E31447@blues.jpj.net>
User-Agent: Mutt/1.5.4i
cc: cvs-all@FreeBSD.org
cc: ports-committers@FreeBSD.org
cc: Pav Lucistnik <pav@FreeBSD.org>
cc: Joe Marcus Clarke <marcus@FreeBSD.org>
cc: cvs-ports@FreeBSD.org
cc: Dag-Erling =?iso-8859-1?Q?Sm=F8rgrav?= <des@des.no>
Subject: Re: cvs commit: ports/www/firefox Makefile distinfo pkg-descr
	pkg-message pkg-plist ports/www/firefox/files firebird.rb
	firefox.rb mkdistfile mozconfig.in patch-Double.cpp
	patch-build_unix_run-mozilla
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 12 Feb 2004 10:30:11 -0000

On Thu, Feb 12, 2004 at 03:38:18AM -0500, Trevor Johnson wrote:
> > IMHO, replacing ${REINPLACE_CMD} with ${PERL} -pi is a regression.
> 
> Were this the only place where the port uses Perl, you would be right.

My opinion is that DES is right anyway.  This lowers the consistency of
the ports tree overall, and it makes it harder to do global statistics
etc.  For each single issue this is not a big deal; however, overall it
IS, and to get overall consistency we need to make consistent choices in
each single case.

At least 99% of the people that still run 4.6 and want to run firefox
will already have REINPLACE installed.  The argument for "less
dependencies" is thus for an extreme minority case, and it is IMO not
one we should take particular care for anyway.  We *want* people to
upgrade, so the net avoids exposure to old versions etc.

My advice: Just accept the use of perl as a mistake, fix it, and move
on.

Eivind.