From owner-cvs-src@FreeBSD.ORG Tue Apr 18 12:56:26 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 038DC16A400; Tue, 18 Apr 2006 12:56:26 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id 672FC43D5D; Tue, 18 Apr 2006 12:56:25 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from zion.baldwin.cx (zion.baldwin.cx [192.168.0.7]) (authenticated bits=0) by server.baldwin.cx (8.13.4/8.13.4) with ESMTP id k3ICuOoJ094093; Tue, 18 Apr 2006 08:56:24 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Gleb Smirnoff Date: Tue, 18 Apr 2006 08:38:02 -0400 User-Agent: KMail/1.8.3 References: <200604171820.k3HIKcx3068404@repoman.freebsd.org> <200604171514.06482.jhb@freebsd.org> <20060418081036.GU84736@FreeBSD.org> In-Reply-To: <20060418081036.GU84736@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset="koi8-r" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Message-Id: <200604180838.03529.jhb@freebsd.org> X-Virus-Scanned: ClamAV 0.87.1/1404/Tue Apr 18 06:03:40 2006 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.0 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.0 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on server.baldwin.cx Cc: cvs-src@freebsd.org, sam@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/hwpmc hwpmc_mod.c src/sys/dev/random randomdev_soft.c src/sys/kern kern_intr.c kern_poll.c kern_synch.c kern_thr.c kern_umtx.c sched_4bsd.c subr_taskqueue.c uipc_mqueue.c src/sys/vm vm_zeroidle.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Apr 2006 12:56:26 -0000 On Tuesday 18 April 2006 04:10 am, Gleb Smirnoff wrote: > On Mon, Apr 17, 2006 at 03:14:03PM -0400, John Baldwin wrote: > J> > Change msleep() and tsleep() to not alter the calling thread's > priority J> > if the specified priority is zero. This avoids a race > where the calling J> > thread could read a snapshot of it's current > priority, then a different J> > thread could change the first thread's > priority, then the original thread J> > would call sched_prio() inside > msleep() undoing the change made by the J> > second thread. I used a > priority of zero as no thread that calls msleep() J> > or tsleep() shou= ld > be specifying a priority of zero anyway. J> > > J> > The various places that passed 'curthread->td_priority' or some > variant J> > as the priority now pass 0. > J> > J> This should fix the problem where the first acpi taskq would run with > J> a bogus priority (the sched_prio() when creating the taskqueue seemed > J> to be ignored). > > Sorry for probably lame guess... Is this going to fix the problem with > ACPI and new taskqueues? No idea. What is the problem? =2D-=20 John Baldwin =9A<>< =9Ahttp://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" =9A=3D =9Ahttp://www.FreeBSD.org