From owner-cvs-all Sat Dec 21 22:34:45 2002 Delivered-To: cvs-all@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 931) id 8069F37B401; Sat, 21 Dec 2002 22:34:42 -0800 (PST) Date: Sat, 21 Dec 2002 22:34:42 -0800 From: Juli Mallett To: ak03@gte.com Cc: tjr@FreeBSD.org, kan@FreeBSD.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/contrib/gcc/config/i386 i386.c Message-ID: <20021221223442.A78839@FreeBSD.org> References: <200212220557.gBM5vr4X024427@repoman.freebsd.org> <20021222170736.A62132@dilbert.robbins.dropbear.id.au> <20021222011116.69fa086e.kabaev@bellatlantic.net> <20021221221249.A77486@FreeBSD.org> <20021222012213.79f62eb0.kabaev@bellatlantic.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <20021222012213.79f62eb0.kabaev@bellatlantic.net>; from kabaev@bellatlantic.net on Sun, Dec 22, 2002 at 01:22:13AM -0500 Organisation: The FreeBSD Project X-Alternate-Addresses: , , , , X-Towel: Yes X-LiveJournal: flata, jmallett X-Negacore: Yes Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG * De: Alexander Kabaev [ Data: 2002-12-21 ] [ Subjecte: Re: cvs commit: src/contrib/gcc/config/i386 i386.c ] > On Sat, 21 Dec 2002 22:12:49 -0800 > Juli Mallett wrote: > > > When will that 3rd (quiet) ABI break be coming? > > The ABI break was unintended and if you have issues with it I suggest > you take it to GCC developers who silently disabled the feature. The > whole FreeBSD community has lived with broken div(3) ever since GCC > 3.2.x was introduced, and the first complaint we received only now. This > speaks volumes about how often functions returning structs by value are > actually used in the wild. I don't see how that changes the fact that code has accidentally established a new ABI, and that we've changed it back to the old behaviour, and I'm going to be sad if there's no note of this somewhere. Even if it's worded like this, if we feel the need to shove around non-existant blame to the GCC people, For a period after the GCC 3.2.x import (from DATE to DATE), GCC used an incompatible form of ABI for returning structures and unions which FreeBSD's GCC maintainers were not aware of relative to previous versions of FreeBSD. We have gone back to the ABI for now, and any code compiled which is required to interoperate with other code (not built at the same time) returning structs or unions should be rebuilt. > The next ABI breakage will most likely come with GCC 3.3. And it will be > loud, believe me. I was referring to the fact that the return to old format came in much the same way as the move to the PCC/SVR4 Elf, despite claims that the other was unexpected, while the latter was intentional. -- Juli Mallett OpenDarwin, Mono, FreeBSD Developer. ircd-hybrid Developer, EFnet addict. FreeBSD on MIPS-Anything on FreeBSD. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message