From owner-freebsd-ports Wed Aug 28 23:13:20 2002 Delivered-To: freebsd-ports@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C2B9937B401 for ; Wed, 28 Aug 2002 23:13:17 -0700 (PDT) Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 77D6A43EDC for ; Wed, 28 Aug 2002 23:12:45 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.4/8.12.4) with ESMTP id g7T6A4JU090311 for ; Wed, 28 Aug 2002 23:10:05 -0700 (PDT) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.4/8.12.4/Submit) id g7T6A43o090309; Wed, 28 Aug 2002 23:10:04 -0700 (PDT) Date: Wed, 28 Aug 2002 23:10:04 -0700 (PDT) Message-Id: <200208290610.g7T6A43o090309@freefall.freebsd.org> To: freebsd-ports@FreeBSD.org Cc: From: Trevor Johnson Subject: Re: ports/42134: linux-gtk PORTREVISION contaminates other ports Reply-To: Trevor Johnson Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org The following reply was made to PR ports/42134; it has been noted by GNATS. From: Trevor Johnson To: "Bruce A. Mah" Cc: FreeBSD-gnats-submit@FreeBSD.ORG Subject: Re: ports/42134: linux-gtk PORTREVISION contaminates other ports Date: Thu, 29 Aug 2002 02:02:19 -0400 (EDT) > Several ports (such as linux-jpeg and linux-png) use the linux-gtk > port's Makefile to provide some of their build infrastructure for > locating RPMs. In order to facilitate this reuse, a number of the > port's Makefile variables are set conditionally (e.g. "PORTNAME?="), > so that they can be overridden by other ports. > > Unfortunately, PORTREVISION isn't one of these. Therefore, any port > that include linux-gtk/Makefile will have a PORTREVISION equal to > whatever linux-gtk uses (currently 2). There is no way for > these other ports to override this setting in their own Makefiles > with PORTREVISION=0. If, instead of including the linux-gtk Makefile, those other ports (and linux-gtk itself) included some other Makefile without a PORTREVISION line, then the problem would be solved, wouldn't it? The appropriate place for such a Makefile would likely be in ports/Mk/ (calling it bsd.redhat.mk could result in legal problems). -- Trevor Johnson To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message