From owner-freebsd-hackers@FreeBSD.ORG Sun Feb 21 04:54:14 2010 Return-Path: Delivered-To: freebsd-hackers@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 72E6A106566B for ; Sun, 21 Feb 2010 04:54:14 +0000 (UTC) (envelope-from bf1783@googlemail.com) Received: from mail-wy0-f182.google.com (mail-wy0-f182.google.com [74.125.82.182]) by mx1.freebsd.org (Postfix) with ESMTP id 0F8E68FC16 for ; Sun, 21 Feb 2010 04:54:13 +0000 (UTC) Received: by wyb40 with SMTP id 40so95133wyb.13 for ; Sat, 20 Feb 2010 20:54:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:mime-version:received:reply-to:date:message-id :subject:from:to:cc:content-type; bh=thMogT4Xri1EiTn3WTAiDnVSKJmmsNYnsocy1EzHBXY=; b=UEc93jAfh9cPkiOQj3c0HEE/Zu8lGV9RH5O4Dg1kN6epe0SjD6BlPGYw/RtZ9yJl3b UtSMUskdQDiuZumwWo5na7M0fBoZHi2w69MRVqsGJUVfwNekiE5zoFN+RcoHYOXShlvY /jcDfDD/cqQHRjUnMh5pCY9BVABpLCd+jZRgw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=mime-version:reply-to:date:message-id:subject:from:to:cc :content-type; b=HILb/fcp652Wim9EwAZ07JaVIKl8JjLxyZyM18vGBqNL2upLIrCLZI9CasK3+dPTS6 wB02hzafCQeqnqtXHzrA8A5/oc7sRIr0D3qRFyPT4gbxzVcjWdWZZc2+ImfoMt/pmHhr cVtSL63C7vtPxJ/1QF6c2K0Hlsy3Qjtk1/c8c= MIME-Version: 1.0 Received: by 10.216.89.130 with SMTP id c2mr2730534wef.44.1266726222449; Sat, 20 Feb 2010 20:23:42 -0800 (PST) Date: Sat, 20 Feb 2010 23:23:42 -0500 Message-ID: From: "b. f." To: freebsd-hackers@FreeBSD.org Content-Type: text/plain; charset=ISO-8859-1 X-Mailman-Approved-At: Sun, 21 Feb 2010 06:21:20 +0000 Cc: Alex RAY , kientzle@FreeBSD.org Subject: Re: GEOM_ULZMA X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: bf1783@gmail.com List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Feb 2010 04:54:14 -0000 >> The code organization depends on what you want to do with it and how you >> want to update the code in the future, if your lzma library is third party. > >LZMA made by Igor Pavlov, and since 4.62 it licensed under Public Domain. >So we can use it, if we need. > >> >> If you never intend to update the lzma code then I guess it's fine to >> embed it in a big .c file. For a port, it doesn't matter much since it >> is your own thing. There are stricter rules on maintainability and style >> if you want it in the base system. > >So, I think right place for lzma library under sys/contrib directory, if I "promise" >maintain it? There are already long-standing plans to import lzma compression libraries into the base system, by the libarchive maintainers. So you will probably have to coordinate with them. They have hooks in the current libarchive sources for native lzma compression, but they reportedly have been waiting for related file formats and compression methods to stabilize before enabling them by default. Pavlov has been making significant changes from release to release, so this may not be the easiest code to maintain.