From owner-svn-src-head@FreeBSD.ORG Fri Jun 5 06:23:33 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 750721065672; Fri, 5 Jun 2009 06:23:33 +0000 (UTC) (envelope-from stas@FreeBSD.org) Received: from mx0.deglitch.com (backbone.deglitch.com [IPv6:2001:16d8:fffb:4::abba]) by mx1.freebsd.org (Postfix) with ESMTP id 29ABC8FC1D; Fri, 5 Jun 2009 06:23:33 +0000 (UTC) (envelope-from stas@FreeBSD.org) Received: from orion.SpringDaemons.com (unknown [77.232.3.143]) by mx0.deglitch.com (Postfix) with ESMTPA id 7EE588FC27; Fri, 5 Jun 2009 10:23:31 +0400 (MSD) Received: from orion (localhost [127.0.0.1]) by orion.SpringDaemons.com (Postfix) with SMTP id 8B36A39C25; Fri, 5 Jun 2009 10:24:31 +0400 (MSD) Date: Fri, 5 Jun 2009 10:24:31 +0400 From: Stanislav Sedov To: Benno Rice Message-Id: <20090605102431.4769115f.stas@FreeBSD.org> In-Reply-To: <200906042343.n54Nh8c5008164@svn.freebsd.org> References: <200906042343.n54Nh8c5008164@svn.freebsd.org> Organization: The FreeBSD Project X-XMPP: ssedov@jabber.ru X-Voice: +7 916 849 20 23 X-Mailer: carrier-pigeon X-PGP-Fingerprint: B83A B15D 929A 364A D8BC B3F9 BF25 A231 092F D9F0 Mime-Version: 1.0 Content-Type: multipart/signed; protocol="application/pgp-signature"; micalg="PGP-SHA1"; boundary="Signature=_Fri__5_Jun_2009_10_24_31_+0400_HLu=XRsZkM+87Tc/" Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r193475 - head/sbin/kldload X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Jun 2009 06:23:34 -0000 --Signature=_Fri__5_Jun_2009_10_24_31_+0400_HLu=XRsZkM+87Tc/ Content-Type: text/plain; charset=US-ASCII Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, 4 Jun 2009 23:43:08 +0000 (UTC) Benno Rice mentioned: > + if (path =3D=3D NULL) { > + err(1, "allocating %lu bytes for the path", > + (unsigned long)pathlen + 1); ^^^^^^^^^^^^^^^^^^^^^^ Why convert pathlen to unsigned long here? The pathlen variable is of size_t type which is already unsigned and we have the special 'z' prefix in printf(3) to print those. --=20 Stanislav Sedov ST4096-RIPE --Signature=_Fri__5_Jun_2009_10_24_31_+0400_HLu=XRsZkM+87Tc/ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- iQIcBAEBAgAGBQJKKLofAAoJEKN82nOYvCd04AwQAK1jmNo+1B8kYedEyHpLgfWY ygHUgNOTuTRxBAByEhv8usOPr8kYo0eWg6wBGjfhaqoxf3Au8qZnhFtF37DqYLVE Fzoy1JIuJrAtKpcFhiKUkZ9Hi8PYSJOhuAI+KzKbGb7GgYB3UssKchBWNcXUI4fV L7Mmy3EMh4FEFJ9vHZpF6WTze5J/05aZs0Z6cPAk9rQNDOoGZ2NloqVVNQixGzPg fUruoY0CbZoniWodr5Icswqx+C5cBy/5Nev5ZksFAQROJhv9xIWuTNlmz+BJwdja I0ByYLcDmhXA3XqvdnDVaydJhEiwXH82MFsygFH6IT9CgGGxZ95WFRDJbf7GGvkw rnmmPb1Si8pFW3hIkNSZPR9Sl0vFxx8pAUmF0l9Yh6Xn7fkDezL6NmSpjqRamjd7 1FwxOqGZiPcEdohTqn3Br+1rgDtyMdc6IASmDAgbUg8uffGemKAQQ5bBjbeemEOb /61wq6vqpLXcmh0u45lFkEKuKHY+nMI5tyam7SJdG4/ys/WyOhwYYfxQs4EmvOf/ P05Za+UxyHXBS40S8UAT1M69lqURilUjXYcK/sGV+ABWNbxP0fRs81XswP7108NQ VlBd9Fn9d4tOIh1fjcLptlO4qvjaDToIYD36BCjjFxBdIKsFDAHT4gbGB+1Hn12W LaABYjRA7gxManMudROL =ww/W -----END PGP SIGNATURE----- --Signature=_Fri__5_Jun_2009_10_24_31_+0400_HLu=XRsZkM+87Tc/--