From owner-cvs-all Mon Apr 2 11:34:41 2001 Delivered-To: cvs-all@freebsd.org Received: from meow.osd.bsdi.com (meow.osd.bsdi.com [204.216.28.88]) by hub.freebsd.org (Postfix) with ESMTP id 3A7AE37B719; Mon, 2 Apr 2001 11:34:36 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: from laptop.baldwin.cx (john@jhb-laptop.osd.bsdi.com [204.216.28.241]) by meow.osd.bsdi.com (8.11.2/8.11.2) with ESMTP id f32IYVG70893; Mon, 2 Apr 2001 11:34:31 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.4.0 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <200104011137.f31BbW162870@freefall.freebsd.org> Date: Mon, 02 Apr 2001 11:34:03 -0800 (PDT) From: John Baldwin To: "David E. O'Brien" Subject: RE: cvs commit: src/lib/libdisk create_chunk.c write_disk.c Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On 01-Apr-01 David E. O'Brien wrote: > obrien 2001/04/01 04:37:31 PDT > > Modified files: > lib/libdisk create_chunk.c write_disk.c > Log: > Try to untangle some of the #ifdef spaghetti. > Also, looking to the future, don't assume all the world is an i386 and all > its disk layout brain damage will be repeated by other platforms. So all > the diking out if we are an Alpha, becomes adding in if we are an i386. Actually, IA64 uses a MBR and slices, too. I'd almost rather you use #ifdef USE_SLICES or something like that and have each arch set appropriate defines to describe its disk layout. -- John Baldwin -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message