From owner-p4-projects  Thu Aug 15  8:56:22 2002
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 291D037B401; Thu, 15 Aug 2002 08:56:18 -0700 (PDT)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 960DC37B400
	for <perforce@freebsd.org>; Thu, 15 Aug 2002 08:56:17 -0700 (PDT)
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 563E343E81
	for <perforce@freebsd.org>; Thu, 15 Aug 2002 08:56:17 -0700 (PDT)
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Received: from freefall.freebsd.org (perforce@localhost [127.0.0.1])
	by freefall.freebsd.org (8.12.4/8.12.4) with ESMTP id g7FFuHJU053870
	for <perforce@freebsd.org>; Thu, 15 Aug 2002 08:56:17 -0700 (PDT)
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Received: (from perforce@localhost)
	by freefall.freebsd.org (8.12.4/8.12.4/Submit) id g7FFuGSD053867
	for perforce@freebsd.org; Thu, 15 Aug 2002 08:56:16 -0700 (PDT)
Date: Thu, 15 Aug 2002 08:56:16 -0700 (PDT)
Message-Id: <200208151556.g7FFuGSD053867@freefall.freebsd.org>
X-Authentication-Warning: freefall.freebsd.org: perforce set sender to bb+lists.freebsd.perforce@cyrus.watson.org using -f
From: Robert Watson <rwatson@FreeBSD.org>
Subject: PERFORCE change 16029 for review
To: Perforce Change Reviews <perforce@freebsd.org>
Sender: owner-p4-projects@FreeBSD.ORG
Precedence: bulk
List-ID: <p4-projects.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20p4-projects>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20p4-projects>
X-Loop: FreeBSD.ORG

http://people.freebsd.org/~peter/p4db/chv.cgi?CH=16029

Change 16029 by rwatson@rwatson_tislabs on 2002/08/15 08:55:28

	Assert process locks in the MAC access control check entry points
	targetting processes.

Affected files ...

.. //depot/projects/trustedbsd/mac/sys/kern/kern_mac.c#243 edit

Differences ...

==== //depot/projects/trustedbsd/mac/sys/kern/kern_mac.c#243 (text+ko) ====

@@ -2576,6 +2576,8 @@
 	if (!mac_enforce_process)
 		return (0);
 
+	PROC_LOCK_ASSERT(proc, MA_OWNED);
+
 	MAC_CHECK(check_proc_debug, cred, proc);
 
 	return (error);
@@ -2589,6 +2591,8 @@
 	if (!mac_enforce_process)
 		return (0);
 
+	PROC_LOCK_ASSERT(proc, MA_OWNED);
+
 	MAC_CHECK(check_proc_sched, cred, proc);
 
 	return (error);
@@ -2602,6 +2606,8 @@
 	if (!mac_enforce_process)
 		return (0);
 
+	PROC_LOCK_ASSERT(proc, MA_OWNED);
+
 	MAC_CHECK(check_proc_signal, cred, proc, signum);
 
 	return (error);

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe p4-projects" in the body of the message